-
Notifications
You must be signed in to change notification settings - Fork 40.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt OpaqueTokenIntrospector auto-configuration so that Nimbus is no longer required #29572
Adapt OpaqueTokenIntrospector auto-configuration so that Nimbus is no longer required #29572
Conversation
this replaces NimbusOpaqueTokenIntrospector as default OpaqueTokenInspector, allowing applications to remove the com.nimbusds:oauth2-oidc-sdk dependency
@lukaskusterbi Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@pivotal-cla This is an Obvious Fix |
@lukaskusterbi This Pull Request contains an obvious fix. Signing the Contributor License Agreement is not necessary. |
@lukaskusterbi unfortunately I don't think that qualifies as an obvious fix. I don't know what we're going to do with this PR but you'll need to sign the CLA if we decide to merge it. |
OK, thanks for the heads-up. I'll need to check with Legal since it's not on our list of approved CLAs. |
@lukaskusterbi Thank you for signing the Contributor License Agreement! |
@jzheaux Is this what the Spring Security team recommends for Spring Boot auto-configuration? |
Yes, @mbhave, |
Shall I adapt the configuration for |
@lukaskusterbi if you have time, please go ahead! You can update this PR by pushing more to the |
this replaces NimbusReactiveOpaqueTokenIntrospector as default ReactiveOpaqueTokenInspector, allowing applications to remove the com.nimbusds:oauth2-oidc-sdk dependency
Thanks very much for making your first contribution to Spring Boot, @lukaskusterbi. |
Since Spring Security implemented their own SpringOpaqueTokenIntrospector (see spring-projects/spring-security#9354), Spring Boot should configure that by default instead of relying on the com.nimbusds:oauth2-oidc-sdk dependency.
This PR replaces the NimbusOpaqueTokenIntrospector with SpringOpaqueTokenIntrospector in the default configuration, allowing applications to remove the com.nimbusds:oauth2-oidc-sdk dependency.