Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpringOpaqueTokenIntrospector #9354

Closed
jzheaux opened this issue Jan 19, 2021 · 3 comments
Closed

Add SpringOpaqueTokenIntrospector #9354

jzheaux opened this issue Jan 19, 2021 · 3 comments
Assignees
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Jan 19, 2021

The extent to which the Nimbus library is used in Nimbus(Reactive)OpaqueTokenIntrospector is minimal enough that there's value in creating Nimbus-free versions in order to simplify dependency management with com.nimbusds:oauth2-oidc-sdk.

These Nimbus-free versions would become the default.

The existing classes use Nimbus for parsing the introspection HTTP response. These new implementations would instead rely on RestTemplate or WebClient to parse the response as a Map of attributes. Now as a Map, the convertClaimSet(TokenIntrospectionSuccessResponse) would become convertClaimSet(Map).

For testing, all the tests in Nimbus(Reactive)OpaqueTokenIntrospector should be applicable for Spring(Reactive)OpaqueTokenIntrospector.

@jzheaux jzheaux added type: enhancement A general enhancement status: ideal-for-contribution An issue that we actively are looking for someone to help us with in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Jan 19, 2021
@mkheck
Copy link
Contributor

mkheck commented Jan 20, 2021

Hi @jzheaux, I'd like to take this one.

@jgrandja jgrandja assigned mkheck and unassigned mkheck May 18, 2021
@jzheaux jzheaux removed the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Jul 16, 2021
@jzheaux jzheaux self-assigned this Jul 16, 2021
@jzheaux jzheaux added this to the 5.6.0-M1 milestone Jul 16, 2021
@eleftherias eleftherias modified the milestones: 5.6.0-M1, 5.6.0-M2 Jul 19, 2021
@jgrandja
Copy link
Contributor

@jzheaux You might want to consider OAuth2TokenIntrospectionHttpMessageConverter as part of this implementation.

@jzheaux
Copy link
Contributor Author

jzheaux commented Jul 27, 2021

Thanks, @jgrandja, I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

4 participants