DATAMONGO-2200 - Derive fields for aggregation $project stage from a given type. #748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophstrobl
force-pushed
the
issue/DATAMONGO-2200
branch
from
51933a8 to
2ac0734
Compare
mp911de
reviewed
May 28, 2019
| public Document toDocument(AggregationOperationContext context) { | ||
|
|
||
| Document projections = new Document(); | ||
| ReflectionUtils.doWithFields(type, it -> projections.append(it.getName(), 1)); |
There was a problem hiding this comment.
We probably should differentiate here and rely on our meta-model. One might want to use property accessors instead or hand in a projection interface.
…given type.
We now allow to derive field names for a $project stage from a given type by including all top level fields.
// $project : { title : 1, author : 1 }
Aggregation.project(Book.class)
Use the mapping context to get the required fields or fall back to property descriptors if no mapping context is available.
christophstrobl
force-pushed
the
issue/DATAMONGO-2200
branch
from
2ac0734 to
13b2fce
Compare
mp911de
pushed a commit
that referenced
this pull request
Jul 2, 2019
…given type.
We now allow to derive field names for a $project stage from a given type by including all top level fields.
// $project : { title : 1, author : 1 }
Aggregation.project(Book.class)
Original pull request: #748.
mp911de
pushed a commit
that referenced
this pull request
Jul 2, 2019
Use the mapping context to get the required fields or fall back to property descriptors if no mapping context is available. Original pull request: #748.
mp911de
added a commit
that referenced
this pull request
Jul 2, 2019
Tweak Javadoc. Simplify Fields creation from Stream. Remove final modifier from private static method. Iterate with loop over PersistentEntity. Original pull request: #748.
|
That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now allow to derive field names for a
$projectstage from a given type by including all top level fields.Requires changes from: #743