DATAMONGO-2320 - Fix aggregation field reference for $filter operator. #776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now render field and local variable references correctly when using the $filter aggregation operator. Prior to this commit field references had been rendered with an additional $ prefix.
EGD
reviewed
Aug 1, 2019
| return new ExpressionFieldReference(delegate.getReference(field)); | ||
|
|
||
| FieldReference reference = delegate.getReference(field); | ||
| return !isInnerVariableReference(field) ? reference : new ExpressionFieldReference(delegate.getReference(field)) ; |
There was a problem hiding this comment.
maybe new ExpressionFieldReference(reference) ; ?
mp911de
pushed a commit
that referenced
this pull request
Aug 2, 2019
We now render field and local variable references correctly when using the $filter aggregation operator. Prior to this commit field references had been rendered with an additional $ prefix. Original pull request: #776.
mp911de
added a commit
that referenced
this pull request
Aug 2, 2019
Use for-loops instead of Stream API and Collectors. Reformat code. Invert condition for smoother readability. Original pull request: #776.
mp911de
pushed a commit
that referenced
this pull request
Aug 2, 2019
We now render field and local variable references correctly when using the $filter aggregation operator. Prior to this commit field references had been rendered with an additional $ prefix. Original pull request: #776.
mp911de
added a commit
that referenced
this pull request
Aug 2, 2019
Use for-loops instead of Stream API and Collectors. Reformat code. Invert condition for smoother readability. Original pull request: #776.
|
That's merged and backported now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now render field and local variable references correctly when using the
$filteraggregation operator.Prior to this commit field references had been rendered with an additional
$prefix.