Skip to content

Add support for CONFIG REWRITE #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add support for CONFIG REWRITE #2012

wants to merge 1 commit into from

Conversation

@manousos
Copy link

@manousos manousos commented Mar 22, 2021

Closes #1992

@manousos
Support rewrite redis.conf file.
216465a 
Signed-off-by: Manousos Mathioudakis <manoumathioudakis@yahoo.gr>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 22, 2021
@mp911de mp911de self-assigned this Mar 22, 2021
@mp911de mp911de changed the title Support rewrite redis.conf file. Add support for CONFIG REWRITE Mar 29, 2021
mp911de pushed a commit that referenced this pull request Mar 29, 2021
@mp911de
Add support for CONFIG REWRITE.
2d56eaf 
Signed-off-by: Manousos Mathioudakis <manoumathioudakis@yahoo.gr>

Closes #1992
Original pull request: #2012.
mp911de added a commit that referenced this pull request Mar 29, 2021
@mp911de
Polishing.
0f6a152 
Reorder methods. Move rewriteConfig directly implemented on connection to DefaultedRedisConnection respective DefaultedRedisClusterConnection.

Add overload to run config rewrite on individual cluster nodes. Add tests. Add since tags and update Javadoc.

See #1992
Original pull request: #2012.
@mp911de
Copy link
Member

mp911de commented Mar 29, 2021

Thank you for your contribution. That's merged and polished now.

@mp911de mp911de closed this Mar 29, 2021
@mp911de mp911de added this to the 2.5 RC1 (2021.0.0) milestone Mar 29, 2021
@mp911de mp911de added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mp911de mp911de

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

2.5 RC1 (2021.0.0)

Development

Successfully merging this pull request may close these issues.

Add support for CONFIG REWRITE

3 participants

@manousos @mp911de @spring-projects-issues