Skip to content

[S1161] use PMD to avoid missing @Override on overriding and implementing methods #35063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from

Conversation

@Pankraz76
Copy link
Author

Pankraz76 commented Jun 16, 2025

how to auto fix build? @bclozel

its not done, out of the box, CoC, like in maven and quarkus, as it should.

Task :spring-aop:checkstyleMain FAILED
[ant:checkstyle] [ERROR] /Users/vincent.potucek/IdeaProjects/spring-framework/spring-aop/src/main/java/org/springframework/aop/support/DelegatingIntroductionInterceptor.java:21:1: 'org.springframework.aop.DynamicIntroductionAdvice' should be separated from previous imports. [ImportOrder]
[ant:checkstyle] [ERROR] /Users/vincent.potucek/IdeaProjects/spring-framework/spring-aop/src/main/java/org/springframework/aop/support/DelegatingIntroductionInterceptor.java:26:1: Wrong order for 'java.util.Objects' import. [ImportOrder]

@bclozel
Copy link
Member

bclozel commented Jun 16, 2025

Thanks for the proposal but we are not interested in using PMD at the moment in our project.
Rather than being prescriptive about styling and rules or focus on cosmetic changes, we would rather value contributions based on bugs encountered in production with your Spring apps or features requests that would help you write Spring apps.

@bclozel bclozel closed this Jun 16, 2025
@bclozel bclozel added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants