Fix unused assignment: the value changed at constructorArgNum++ is never used

[Pankraz76]

• Fix unused assignment: the value changed at constructorArgNum++ is never used

100% (1/1)	75% (3/4)	78% (54/69)	68% (26/38)

�

100% (1/1)	100% (4/4)	91% (63/69)	84% (32/38)

�

[Pankraz76]

please give me a change to improve QA, as dev team does not have resources to take care about quality in details.

im here to server the needs of spring.

@bclozel

its all related to toleration of chaos, instead of lead by example using proper tooling.

• [S1161] use PMD to avoid missing @Override on overriding and implementing methods #35063

[Pankraz76]

build is not fixing whitespaces like maven or quarkus does.

• PoC: integrate Eclipse Formatter Profile into Maven Spotless Plugin #34978
• (re)activate maven.compiler.release thus consolidate spotless-maven-plugin, impsort-maven-plugin, and PMD to fix UnnecessaryImport quarkusio/quarkus#48414
• Use Spotless as format plugin, it covers existing plugins import and format quarkusio/quarkus#48383

Assuming its not configured properly to apply mentioned auto fix

• https://github.com/spring-io/spring-javaformat

How to fix these flaws, as not done with gradle clean build?

Dont want to spend time in whitespaces, thank you.

> Task :spring-context:checkstyleTest
[ant:checkstyle] [ERROR] /Users/vincent.potucek/IdeaProjects/spring-framework/spring-context/src/test/java/org/springframework/scripting/config/ScriptBeanDefinitionParserTest.java:1: File does not end with a newline. [NewlineAtEndOfFile]
[ant:checkstyle] [ERROR] /Users/vincent.potucek/IdeaProjects/spring-framework/spring-context/src/test/java/org/springframework/scripting/config/ScriptBeanDefinitionParserTest.java:1: Line does not match expected header line of '^\Q/*\E$'. [SpringHeader]
[ant:checkstyle] [ERROR] /Users/vincent.potucek/IdeaProjects/spring-framework/spring-context/src/test/java/org/springframework/scripting/config/ScriptBeanDefinitionParserTest.java:3:1: Illegal import - org.junit.jupiter.api.Test. [bannedJUnitJupiterImports]
[ant:checkstyle] [ERROR] /Users/vincent.potucek/IdeaProjects/spring-framework/spring-context/src/test/java/org/springframework/scripting/config/ScriptBeanDefinitionParserTest.java:4:1: 'org.springframework.beans.factory.support.BeanDefinitionDefaults' should be separated from previous imports. [ImportOrder]
[ant:checkstyle] [ERROR] /Users/vincent.potucek/IdeaProjects/spring-framework/spring-context/src/test/java/org/springframework/scripting/config/ScriptBeanDefinitionParserTest.java:6:1: Wrong order for 'org.w3c.dom.Element' import. [ImportOrder]
[ant:checkstyle] [ERROR] /Users/vincent.potucek/IdeaProjects/spring-framework/spring-context/src/test/java/org/springframework/scripting/config/ScriptBeanDefinitionParserTest.java:8:1: 'org.springframework.beans.factory.config.ConstructorArgumentValues.ValueHolder' should be separated from previous imports. [ImportOrder]
[ant:checkstyle] [ERROR] /Users/vincent.potucek/IdeaProjects/spring-framework/spring-context/src/test/java/org/springframework/scripting/config/ScriptBeanDefinitionParserTest.java:14: Please use AssertJ assertions. [junitJupiterAssertions]
[ant:checkstyle] [ERROR] /Users/vincent.potucek/IdeaProjects/spring-framework/spring-context/src/test/java/org/springframework/scripting/config/ScriptBeanDefinitionParserTest.java:14:1: Illegal import - org.junit.jupiter.api.Assertions.*. [bannedJUnitJupiterImports]
[ant:checkstyle] [ERROR] /Users/vincent.potucek/IdeaProjects/spring-framework/spring-context/src/test/java/org/springframework/scripting/config/ScriptBeanDefinitionParserTest.java:14:47: Using the '.*' form of import should be avoided - org.junit.jupiter.api.Assertions.*. [AvoidStarImport]
[ant:checkstyle] [ERROR] /Users/vincent.potucek/IdeaProjects/spring-framework/spring-context/src/test/java/org/springframework/scripting/config/ScriptBeanDefinitionParserTest.java:15:34: Using the '.*' form of import should be avoided - org.mockito.Mockito.*. [AvoidStarImport]
[ant:checkstyle] [ERROR] /Users/vincent.potucek/IdeaProjects/spring-framework/spring-context/src/test/java/org/springframework/scripting/config/ScriptBeanDefinitionParserTest.java:20:7: Class name 'ScriptBeanDefinitionParserTest' must not end with 'Test' (checked pattern '^[A-Z][a-zA-Z0-9_$]*(?<!Test)$'). [TypeName]

[Pankraz76]

why not forbid import ? and migrate existing?

ant:checkstyle] [ERROR] /Users/vincent.potucek/IdeaProjects/spring-framework/spring-context/src/test/java/org/springframework/scripting/config/ScriptBeanDefinitionParserTest.java:17: Please use AssertJ assertions. [junitJupiterAssertions]

• https://docs.openrewrite.org/recipes/java/testing/assertj/junittoassertj

[Pankraz76]

thanks for telling me its wrong, but how to fix this?

➜ spring-context git:(fix-The-value-changed-at-'constructorArgNum++'-is-never-used-) gis

Task :spring-context:checkstyleTest
[ant:checkstyle] [ERROR] /Users/vincent.potucek/IdeaProjects/spring-framework/spring-context/src/test/java/org/springframework/scripting/config/ScriptBeanDefinitionParser2Tests.java:30:1: Wrong order for 'org.w3c.dom.Element' import. [ImportOrder]

Task :spring-context:checkstyleTest FAILED

[Incubating] Problems report is available at: file:///Users/vincent.potucek/IdeaProjects/spring-framework/build/reports/problems/problems-report.html

FAILURE: Build failed with an exception.

• What went wrong:
  Execution failed for task ':spring-context:checkstyleTest'.

A failure occurred while executing org.gradle.api.plugins.quality.internal.CheckstyleAction
Checkstyle rule violations were found. See the report at: file:///Users/vincent.potucek/IdeaProjects/spring-framework/spring-context/build/reports/checkstyle/test.html
Checkstyle files with violations: 1
Checkstyle violations by severity: [error:1]

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

For more on this, please refer to https://docs.gradle.org/8.14.2/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.

BUILD FAILED in 7s
55 actionable tasks: 1 executed, 54 up-to-date
➜ spring-context git:(fix-The-value-changed-at-'constructorArgNum++'-is-never-used-)

try and error very expensive

as its only 1 <importOrder> element to fix:

• automate import correction with Maven Spotless Plugin pmd/pmd#5776

note, has to be like this:

import org.assertj.core.api.InstanceOfAssertFactories;
import org.junit.jupiter.api.Test;
import org.w3c.dom.Element;
import org.w3c.dom.NodeList;

import org.springframework.beans.factory.config.ConstructorArgumentValues.ValueHolder;
import org.springframework.beans.factory.config.RuntimeBeanReference;
import org.springframework.beans.factory.support.AbstractBeanDefinition;
import org.springframework.beans.factory.support.BeanDefinitionDefaults;
import org.springframework.beans.factory.xml.BeanDefinitionParserDelegate;
import org.springframework.beans.factory.xml.ParserContext;
import org.springframework.beans.factory.xml.XmlReaderContext;

import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.Mockito.any;
import static org.mockito.Mockito.anyString;
import static org.mockito.Mockito.doNothing;
import static org.mockito.Mockito.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
import static org.springframework.beans.factory.xml.BeanDefinitionParserDelegate.DESTROY_METHOD_ATTRIBUTE;
import static org.springframework.beans.factory.xml.BeanDefinitionParserDelegate.INIT_METHOD_ATTRIBUTE;
import static org.springframework.scripting.support.ScriptFactoryPostProcessor.PROXY_TARGET_CLASS_ATTRIBUTE;

[Pankraz76]

kindly request some feedback.

[bclozel]

Unless you have found an issue while writing a Spring application, I don't think we should invest time in this.