Skip to content

ResourceAssemblerSupport.toResources() should return Resources<D> instead of List<D> #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JakobFels opened this issue Nov 19, 2015 · 0 comments
Closed

ResourceAssemblerSupport.toResources() should return Resources<D> instead of List<D> #416

JakobFels opened this issue Nov 19, 2015 · 0 comments
Assignees
@gregturn
Labels
type: new feature
Milestone
1.0 M1

Comments

@JakobFels
Copy link

When exposing a Collection as a Resource, it is counter intuitive to have to wrap the result of toResources() into an Object of Resources.

List<DomainObject> objects = domainRepository.findAll();
List<DomainResource> resources = myResourceAssembler.toResources(objects);
Resources<DomainResource> resourcesWrapped = new Resources<>(resources);
//Add links to resources etc...

Ideally, toResources should actually return Resources, like the name implies.
@gregturn gregturn self-assigned this May 23, 2017
gregturn added a commit that referenced this issue May 23, 2017
@gregturn
#445 - Make ResourceAssemblerSupport extensible
6dda30d 
Adds getters to allow implementers access to controllerClass and resourceType.

Related issues: #416
gregturn added a commit that referenced this issue May 23, 2017
@gregturn
#572 - Create SimpleResourceAssembler for Resource<T>
36c34a7 
Implement a ResourceAssembler that returns a Resource<T> solely based on a non-Resource domain class.

Related issues: #416
@gregturn gregturn mentioned this issue May 23, 2017
Closed
@gregturn gregturn mentioned this issue Sep 18, 2017
Closed
gregturn added a commit that referenced this issue Sep 26, 2017
@gregturn
#416 - Alter ResourceAssemblerSupport.toResources to return Resources
5e70d86 
To avoid confusion about what to return on a Spring MVC endpoint, change toResources to not return `List<D>`, but instead `Resources<D>`. This clearly ensures when used to construct Spring MVC endpoints, will return a type Spring HATEOAS will properly marshal.

Related issues: #493
Related pull requests: #572
gregturn added a commit that referenced this issue Sep 26, 2017
@gregturn
#416 - Alter ResourceAssemblerSupport.toResources to return Resources
162bd31 
To avoid confusion about what to return on a Spring MVC endpoint, change toResources to not return `List<D>`, but instead `Resources<D>`. This clearly ensures when used to construct Spring MVC endpoints, will return a type Spring HATEOAS will properly marshal.

Related issues: #493
Related pull requests: #572
gregturn added a commit that referenced this issue Sep 10, 2018
@gregturn
#572 - Create SimpleResourceAssembler for Resource<T>
c8ab873 
Implement a ResourceAssembler that returns a Resource<T> solely based on a non-Resource domain class.

Related issues: #416
gregturn added a commit that referenced this issue Sep 10, 2018
@gregturn
#572 - Create SimpleResourceAssembler for Resource<T>.
3574919 
Implement a ResourceAssembler that returns a Resource<T> solely based on a non-Resource domain class.

Related issues: #416
gregturn added a commit that referenced this issue Sep 10, 2018
@gregturn
#445 - Make ResourceAssemblerSupport extensible
c5168d9 
Adds getters to allow implementers access to controllerClass and resourceType.

Related issues: #416
gregturn added a commit that referenced this issue Sep 10, 2018
@gregturn
#445 - Make ResourceAssemblerSupport extensible
914320a 
Adds getters to allow implementers access to controllerClass and resourceType.

Related issues: #416
gregturn added a commit that referenced this issue Dec 6, 2018
@gregturn
#416 - Alter ResourceAssemblerSupport.toResources to return Resources
8c4884f 
To avoid confusion about what to return on a Spring MVC endpoint, change toResources to not return `List<D>`, but instead `Resources<D>`. This clearly ensures when used to construct Spring MVC endpoints, will return a type Spring HATEOAS will properly marshal.

Related issues: #493
Related pull requests: #572
gregturn added a commit that referenced this issue Dec 6, 2018
@gregturn
#416 - Alter ResourceAssemblerSupport.toResources to return Resources
3b8a3d1 
To avoid confusion about what to return on a Spring MVC endpoint, change toResources to not return `List<D>`, but instead `Resources<D>`. This clearly ensures when used to construct Spring MVC endpoints, will return a type Spring HATEOAS will properly marshal.

Related issues: #493
Related pull requests: #572
gregturn added a commit that referenced this issue Dec 6, 2018
@gregturn
#416 - Alter ResourceAssemblerSupport.toResources to return Resources.
f29f88c 
To avoid confusion about what to return on a Spring MVC endpoint, change toResources to not return `List<D>`, but instead `Resources<D>`. This clearly ensures when used to construct Spring MVC endpoints, will return a type Spring HATEOAS will properly marshal.

To support people that have already built apps on top of Lists, include a `toList<D>` method that honors the old contract.

Related issues: #493
Related pull requests: #572

Hack
@schauder schauder mentioned this issue Dec 18, 2018
Closed
gregturn added a commit that referenced this issue Dec 18, 2018
@gregturn
#416 - Alter ResourceAssemblerSupport.toResources to return Resources.
a597960 
To avoid confusion about what to return on a Spring MVC endpoint, change toResources to not return `List<D>`, but instead `Resources<D>`. This clearly ensures when used to construct Spring MVC endpoints, will return a type Spring HATEOAS will properly marshal.

To support people that have already built apps on top of Lists, include a `toList<D>` method that honors the old contract.

Related issues: #493
Related pull requests: #572
@gregturn gregturn added this to the 1.0 M1 milestone Dec 18, 2018
gregturn added a commit that referenced this issue Dec 18, 2018
@gregturn
#572 - Create SimpleResourceAssembler for Resource<T>.
59d60b6 
Implement a ResourceAssembler that returns a Resource<T> solely based on a non-Resource domain class.

Related issues: #416
gregturn added a commit that referenced this issue Dec 18, 2018
@gregturn
#572 - Create SimpleResourceAssembler for Resource<T>.
f65a012 
Implement a ResourceAssembler that returns a Resource<T> solely based on a non-Resource domain class.

Related issues: #416
gregturn added a commit that referenced this issue Dec 18, 2018
@gregturn
#572 - Create SimpleResourceAssembler for Resource<T>.
cb9d84f 
Implement a ResourceAssembler based solely on a domain type, returning Resource<T> for the `toResource(obj)` method.

Related issues: #416
gregturn added a commit that referenced this issue Dec 18, 2018
@gregturn
#572 - Create SimpleResourceAssembler for Resource<T>.
7853e1f 
Implement a ResourceAssembler based solely on a domain type, returning Resource<T> for the `toResource(obj)` method.

Related issues: #416
gregturn added a commit that referenced this issue Dec 18, 2018
@gregturn
#572 - Create SimpleResourceAssembler for Resource<T>.
d7e9c29 
Implement a ResourceAssembler based solely on a domain type, returning Resource<T> for the `toResource(obj)` method.

Related issues: #416
gregturn added a commit that referenced this issue Dec 18, 2018
@gregturn
#572 - Create SimpleResourceAssembler for Resource<T>.
d89ba43 
Implement a ResourceAssembler based solely on a domain type, returning Resource<T> for the `toResource(obj)` method.

Related issues: #416
gregturn added a commit that referenced this issue Dec 19, 2018
@gregturn
#572 - Create SimpleResourceAssembler for Resource<T>.
a56392a 
Implement a ResourceAssembler based solely on a domain type, returning Resource<T> for the `toResource(obj)` method.

Related issues: #416
@gregturn gregturn mentioned this issue Dec 20, 2018
Closed
@gregturn gregturn mentioned this issue Mar 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregturn gregturn

Labels
type: new feature
Projects
None yet
Milestone
1.0 M1
Development

No branches or pull requests
2 participants
@gregturn @JakobFels