Skip to content

Enhance ResourceAssemblerSupport to allow generics #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gregturn opened this issue Mar 31, 2017 · 1 comment
Closed

Enhance ResourceAssemblerSupport to allow generics #572

gregturn opened this issue Mar 31, 2017 · 1 comment
Assignees
@gregturn
Labels
type: enhancement
Milestone
1.0 M1

Comments

@gregturn
Copy link
Contributor

Currently, ResourceAssemblerSupport requires making the domain object either subclass ResourceSupport (like EmployeeResource extends ResourceSupport) or creating a separate class (like class EmployeeResource extends Resource<Employee>).

If we could extract the core code that presumes a class signature of ResourceAssemblerSupport<Employee>, presuming the target resource type is Resource<Employee>, that would make many things simpler.
@gregturn gregturn self-assigned this Mar 31, 2017
@gregturn gregturn mentioned this issue May 23, 2017
Closed
gregturn added a commit that referenced this issue May 23, 2017
@gregturn
#572 - Create SimpleResourceAssembler for Resource<T>
0865555 
Implement a ResourceAssembler that returns a Resource<T> solely based on a non-Resource domain class.
gregturn added a commit that referenced this issue May 23, 2017
@gregturn
#572 - Create SimpleResourceAssembler for Resource<T>
36c34a7 
Implement a ResourceAssembler that returns a Resource<T> solely based on a non-Resource domain class.

Related issues: #416
gregturn added a commit that referenced this issue Sep 26, 2017
@gregturn
#416 - Alter ResourceAssemblerSupport.toResources to return Resources
5e70d86 
To avoid confusion about what to return on a Spring MVC endpoint, change toResources to not return `List<D>`, but instead `Resources<D>`. This clearly ensures when used to construct Spring MVC endpoints, will return a type Spring HATEOAS will properly marshal.

Related issues: #493
Related pull requests: #572
@gregturn gregturn mentioned this issue Sep 26, 2017
Closed
gregturn added a commit that referenced this issue Sep 26, 2017
@gregturn
#416 - Alter ResourceAssemblerSupport.toResources to return Resources
162bd31 
To avoid confusion about what to return on a Spring MVC endpoint, change toResources to not return `List<D>`, but instead `Resources<D>`. This clearly ensures when used to construct Spring MVC endpoints, will return a type Spring HATEOAS will properly marshal.

Related issues: #493
Related pull requests: #572
gregturn added a commit that referenced this issue Sep 10, 2018
@gregturn
#572 - Create SimpleResourceAssembler for Resource<T>
c8ab873 
Implement a ResourceAssembler that returns a Resource<T> solely based on a non-Resource domain class.

Related issues: #416
gregturn added a commit that referenced this issue Sep 10, 2018
@gregturn
#572 - Create SimpleResourceAssembler for Resource<T>.
3574919 
Implement a ResourceAssembler that returns a Resource<T> solely based on a non-Resource domain class.

Related issues: #416
gregturn added a commit that referenced this issue Dec 6, 2018
@gregturn
#416 - Alter ResourceAssemblerSupport.toResources to return Resources
8c4884f 
To avoid confusion about what to return on a Spring MVC endpoint, change toResources to not return `List<D>`, but instead `Resources<D>`. This clearly ensures when used to construct Spring MVC endpoints, will return a type Spring HATEOAS will properly marshal.

Related issues: #493
Related pull requests: #572
gregturn added a commit that referenced this issue Dec 6, 2018
@gregturn
#416 - Alter ResourceAssemblerSupport.toResources to return Resources
3b8a3d1 
To avoid confusion about what to return on a Spring MVC endpoint, change toResources to not return `List<D>`, but instead `Resources<D>`. This clearly ensures when used to construct Spring MVC endpoints, will return a type Spring HATEOAS will properly marshal.

Related issues: #493
Related pull requests: #572
gregturn added a commit that referenced this issue Dec 6, 2018
@gregturn
#416 - Alter ResourceAssemblerSupport.toResources to return Resources.
f29f88c 
To avoid confusion about what to return on a Spring MVC endpoint, change toResources to not return `List<D>`, but instead `Resources<D>`. This clearly ensures when used to construct Spring MVC endpoints, will return a type Spring HATEOAS will properly marshal.

To support people that have already built apps on top of Lists, include a `toList<D>` method that honors the old contract.

Related issues: #493
Related pull requests: #572

Hack
gregturn added a commit that referenced this issue Dec 18, 2018
@gregturn
#416 - Alter ResourceAssemblerSupport.toResources to return Resources.
a597960 
To avoid confusion about what to return on a Spring MVC endpoint, change toResources to not return `List<D>`, but instead `Resources<D>`. This clearly ensures when used to construct Spring MVC endpoints, will return a type Spring HATEOAS will properly marshal.

To support people that have already built apps on top of Lists, include a `toList<D>` method that honors the old contract.

Related issues: #493
Related pull requests: #572
gregturn added a commit that referenced this issue Dec 18, 2018
@gregturn
#572 - Create SimpleResourceAssembler for Resource<T>.
59d60b6 
Implement a ResourceAssembler that returns a Resource<T> solely based on a non-Resource domain class.

Related issues: #416
gregturn added a commit that referenced this issue Dec 18, 2018
@gregturn
#572 - Create SimpleResourceAssembler for Resource<T>.
f65a012 
Implement a ResourceAssembler that returns a Resource<T> solely based on a non-Resource domain class.

Related issues: #416
gregturn added a commit that referenced this issue Dec 18, 2018
@gregturn
#572 - Create SimpleResourceAssembler for Resource<T>.
cb9d84f 
Implement a ResourceAssembler based solely on a domain type, returning Resource<T> for the `toResource(obj)` method.

Related issues: #416
gregturn added a commit that referenced this issue Dec 18, 2018
@gregturn
#572 - Create SimpleResourceAssembler for Resource<T>.
7853e1f 
Implement a ResourceAssembler based solely on a domain type, returning Resource<T> for the `toResource(obj)` method.

Related issues: #416
gregturn added a commit that referenced this issue Dec 18, 2018
@gregturn
#572 - Create SimpleResourceAssembler for Resource<T>.
d7e9c29 
Implement a ResourceAssembler based solely on a domain type, returning Resource<T> for the `toResource(obj)` method.

Related issues: #416
gregturn added a commit that referenced this issue Dec 18, 2018
@gregturn
#572 - Create SimpleResourceAssembler for Resource<T>.
d89ba43 
Implement a ResourceAssembler based solely on a domain type, returning Resource<T> for the `toResource(obj)` method.

Related issues: #416
schauder added a commit that referenced this issue Dec 19, 2018
@schauder
#572 - Polishing.
4eba09d 
Removed redundant asserts.
schauder added a commit that referenced this issue Dec 19, 2018
@schauder
#572 - !!!!! Review and fix please !!!! Polishing.
da8800a 
Fixed test with missing assertions.

IdentifiableResourceAssemblerSupportUnitTest.unwrapsIdentifyablesForParameters now fails and I'm not sure how it really should look like.

Also: My formatter just removed the blank line in the imports that yours probably introduced.
Which one is the right one?
gregturn added a commit that referenced this issue Dec 19, 2018
@gregturn
#572 - Create SimpleResourceAssembler for Resource<T>.
a56392a 
Implement a ResourceAssembler based solely on a domain type, returning Resource<T> for the `toResource(obj)` method.

Related issues: #416
gregturn pushed a commit that referenced this issue Dec 19, 2018
@schauder @gregturn
#572 - Polishing.
2882e82 
Removed redundant asserts.
@gregturn
Copy link
Contributor Author

Resolved via a56392a.

@gregturn gregturn added this to the 1.0 M1 milestone Dec 21, 2018
@gregturn gregturn mentioned this issue Jan 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gregturn gregturn

Labels
type: enhancement
Projects
None yet
Milestone
1.0 M1
Development

No branches or pull requests
1 participant
@gregturn