Apply NullAbility to scripting module #10293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to: spring-projects#10083 Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
…ource` Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
artembilan
requested changes
Aug 11, 2025
|
|
||
| @Override | ||
| protected ScriptSource getScriptSource(Message<?> message) { | ||
| protected ScriptSource getScriptSource(@Nullable Message<?> message) { |
There was a problem hiding this comment.
Let's fix ScriptExecutingMessageSource instead providing a fake message instance!
The MessageProcessor cotnract is to not accept null for the message argument.
That could be a static final property in the ScriptExecutingMessageSource with byte[0] as payload.
| private @Nullable ClassLoader beanClassLoader; | ||
|
|
||
| private BeanFactory beanFactory; | ||
| private @Nullable BeanFactory beanFactory; |
There was a problem hiding this comment.
Both of these should be NullAway.Init
|
|
||
| public Map<String, Object> generateScriptVariables(Message<?> message) { | ||
| Map<String, Object> scriptVariables = new HashMap<String, Object>(); | ||
| public Map<String, Object> generateScriptVariables(@Nullable Message<?> message) { |
There was a problem hiding this comment.
After fixing ScriptExecutingMessageSource many of these @Nullable on message would go away.
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #10083