Multiple PropertyPlaceholderConfigurers fail in AbstractObjectFactory #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thorstenbaek
changed the title
|
Changed OrderComparer to ObjectOrderComparer. After digging more into the code I discovered that the PPCs are wrapped in adapters not implementing IOrder before beeing added to the SortedSet. |
sbohlen
added a commit
that referenced
this pull request
Nov 22, 2015
Multiple PropertyPlaceholderConfigurers fail in AbstractObjectFactory
|
@sbohlen, sorry but 2.0.1 (April 2015) is still the latest version on NuGet. Is that fix supposed to be released? I Just upgraded my huge production project to 2.0.1 and got the same issue. |
any news about this package? I have the same issue, I'm trying to build the source code at this point with vs2015 and Win10 with no success. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered a possible bug in AbstractObjectFactory when upgrading from Spring.Net 1.3.1 to 2.0.0
Our usage of multiple PropertyPlaceholderConfigurers in different context files failed with the following error:
Spring.Objects.ObjectsException : Errored while postprocessing an object factory. ----> System.InvalidOperationException : Failed to compare two elements in the array. ----> System.ArgumentException : At least one object must implement IComparable.
The IOrder interface implemented in PPC is not used and IComparable is not implemented leading to this error. Adding a OrderComparer to the SortedSet constructor fixes this problem.
I added a new test to PropertyPlaceholderConfigurerTests which reproduces this error.
best regards
Thor Stenbæk