-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Rewrite AbstractAuthenticationTargetUrlRequestHandler#determineTargetUrl logic for clarity #12468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...ramework/security/web/authentication/AbstractAuthenticationTargetUrlRequestHandlerTests.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @dkodippily! I've left some feedback inline. Also, once you get to refactoring the class under test, will you please squash your commits like so:
- one commit for the tests, followed by
- one commit for the refactor
The first commit should end with Issue gh-12344
and the second comment should end with Closes gh-12344
.
...ramework/security/web/authentication/AbstractAuthenticationTargetUrlRequestHandlerTests.java
Outdated
Show resolved
Hide resolved
...ramework/security/web/authentication/AbstractAuthenticationTargetUrlRequestHandlerTests.java
Outdated
Show resolved
Hide resolved
@jzheaux Thanks for the comments , I've added the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @dkodippily! I've left some feedback inline about the latest changes.
...ringframework/security/web/authentication/AbstractAuthenticationTargetUrlRequestHandler.java
Outdated
Show resolved
Hide resolved
...ringframework/security/web/authentication/AbstractAuthenticationTargetUrlRequestHandler.java
Outdated
Show resolved
Hide resolved
...ramework/security/web/authentication/AbstractAuthenticationTargetUrlRequestHandlerTests.java
Outdated
Show resolved
Hide resolved
...ringframework/security/web/authentication/AbstractAuthenticationTargetUrlRequestHandler.java
Outdated
Show resolved
Hide resolved
Thanks , @jzheaux , I've pushed the changes. |
Thanks, @dkodippily! This is now merged into |
Thank you @jzheaux for the support and guidance, planning to pick another issue soon :) |
Added new test class AbstractAuthenticationTargetUrlRequestHandlerTests to confirm AbstractAuthenticationTargetUrlRequestHandler. determineTargetUrl() behaviour.