Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Try PySide6 on conda #378

Merged
merged 5 commits into from
Oct 21, 2022
Merged

PR: Try PySide6 on conda #378

merged 5 commits into from
Oct 21, 2022

Conversation

jschueller
Copy link
Contributor

@jschueller jschueller commented Oct 20, 2022 •
edited by dalthviz
Loading

  • seems QLibraryInfo.location crashes with conda on the CI job (ok locally), so skip that one
  • qtdesigner is not available yet on conda, so can be other modules, we allow that to avoid some tests to fail if the package is not installed

Part of #375

@jschueller jschueller force-pushed the pyside6_conda branch 3 times, most recently from 45b6a10 to add8a5c Compare October 20, 2022 14:21
@jschueller jschueller marked this pull request as ready for review October 20, 2022 14:31
@jschueller jschueller force-pushed the pyside6_conda branch 3 times, most recently from 535db3c to 4ef09c8 Compare October 20, 2022 15:09
dalthviz
dalthviz reviewed Oct 20, 2022
View reviewed changes
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jschueller for the help with this and pushing PySide6 to be available through conda-forge! I left a comment and a suggestion regarding the QtCore.QLibraryInfo.location and passing a PySide6 version to the tests setup script for the future.

Regarding the importskip statement I think we can leave them like that for the moment (maybe in the future we can check if adding more specific skipif annotations is worthy).

Also, seems like some test hanged but I don't see the logs for them so if those also pass after a new push with changes I think this LGTM 👍

qtpy/tests/test_qtcore.py Outdated Show resolved Hide resolved
.github/workflows/test.sh Outdated Show resolved Hide resolved
@dalthviz dalthviz added this to the v2.3.0 milestone Oct 20, 2022
@jschueller
Copy link
Contributor Author

jschueller commented Oct 21, 2022 •
edited
Loading

You were right for QLibraryInfo
Seems it hangs on windows, let's skip it for now

dalthviz
dalthviz approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jschueller !

@dalthviz dalthviz merged commit f5581bd into spyder-ide:master Oct 21, 2022
@jschueller jschueller deleted the pyside6_conda branch October 21, 2022 17:36
@dalthviz dalthviz modified the milestones: v2.3.0, v2.2.2 Oct 31, 2022
@dalthviz dalthviz changed the title CI: Try PySide6 on conda PR: Try PySide6 on conda Nov 1, 2022
@CAM-Gerlach CAM-Gerlach mentioned this pull request Dec 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments

@dalthviz dalthviz dalthviz approved these changes

Assignees

@jschueller jschueller

Labels
type:Task
Projects
None yet
Milestone
v2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jschueller @dalthviz @CAM-Gerlach