-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add Python 3.11 to CIs/tags & overhaul CI config #392
Conversation
d55bdb6
to
f667124
Compare
d9846b2
to
e7a6ba7
Compare
20a35f8
to
23949e9
Compare
@ccordoba12 @dalthviz I've apparently discovered a conda dependency solution issue that can be worked around here, but should probably be fixed properly upstream, most likely with a new release of the conda create -n test-env python=3.11 pyqt qt or equivalently conda create -n test-env python=3.11 pyqt=5.15 qt=5.15 fails on all platforms with a dependency resolution error, which you can see the full output of on CI in e.g. this run. Specifically, I've traced the issue to following three incompatible constraints:
To note, conda create -n test-env python=3.11 pyqt=5.15.7 qt-main=5.15.6 qt-webengine=5.15.4 does resolve. Also, 5.15.4 is the latest version of Should this be reported to one or more of those feedstocks? Or can something else be done about it? |
806fa7b
to
685c189
Compare
685c189
to
38da4d0
Compare
I think it should be reported in the qt-feedstock to update the constraints it has on |
Thanks, I've opened conda-forge/qt-feedstock#234 on there as suggested. In the meantime, though, that doesn't block this PR, since I implemented a workaround (that's not quite as elegant as I'd like, but works just fine for now). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small suggestions for you @CAM-Gerlach, otherwise looks good to me.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now, thanks @CAM-Gerlach!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @CAM-Gerlach !
As discussed in #386 , adds official support for Python 3.11 (following a similar template to #296 which added 3.10 support) in the Trove tags and CI tests, making the necessary binding and Qt version adjustments as required for the 3.11 jobs, including a somewhat non-ideal but necessary workaround for a conda package solver incompatibility on Py311 + pyqt 5.15 + qt 5.15.
Along the way, I've refactored the CI config to centralize the binding and Qt API version selection all in one place in the matrix config, to greatly reduce duplication of version constants and the scattering of the logic multiple places in the declarative config and the dynamic execution script. In concert with that, I've been able to:
conda install
call for PySide6 and fix its indent (from PR PR: Try PySide6 on conda #378)test.sh
, including a small but meaningful typo in a comment, an unnecessarypip
spec/version, and a tab/spaces problemI've also updated/fixed a few related small ancillary bits:
checkout
andsetup-python
action versions to the currentwheel
build-time dependencylicense_file
metadata key superceded bylicense_files
Fixes #386