Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/update links to separate M1 and Intel macOS installers #359

Merged

Conversation

CAM-Gerlach
Copy link
Member

Pull Request

Pull Request Checklist

  • Read and followed this repo's Contributing Guidelines
  • Based your PR on the latest version of the correct branch (master or 4.x)
  • Checked your writing carefully for correct English spelling, grammar, etc
  • Described your changes and the motivation for them below
  • Noted what issue(s) this pull request resolves, creating one if needed

Description of Changes

As fixed for the Spyder website in spyder-ide/website-spyder#223 , the download link for macOS now 404s (as correctly detected by sphinx linkcheck due to the Mac installers being renamed with the 5.5.1 release recently and split into x86-64 (Intel) and ARM64 (M1) versions. The simplest fix for now was to just split the existing macOS download button into two, which is exactly what this PR does.

Merging this will fix the linkcheck failure first seen on PR #358 .

@CAM-Gerlach CAM-Gerlach added type:Spyder Change 5.x Issues specific to the 5.x branch labels Feb 14, 2024
@CAM-Gerlach CAM-Gerlach self-assigned this Feb 14, 2024
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @CAM-Gerlach!

@ccordoba12 ccordoba12 merged commit a509747 into spyder-ide:master Feb 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.x Issues specific to the 5.x branch type:Spyder Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants