Fix download button on macOS & add M1 and Intel options #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Feb 8, 2024
There was a problem hiding this comment.
Small comment for you @CAM-Gerlach, the rest looks good to me.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The website's download button causes a 404 on macOS (Intel and M1) due to the Mac installers being renamed with the 5.5.1 release yesterday and split into x86-64 (Intel) and ARM64 (M1) versions. Unfortunately [it is not reliably possible to detect M1 vs Intel cross-browser and cross-version(https://stackoverflow.com/questions/65146751/detecting-apple-silicon-mac-in-javascript), so the simplest and most reliable solution for now is to just offer two buttons on macOS, one for Intel and one for M1.
For this, I modified the custom function that selects and generates the buttons to handle an arbitrary number of buttons per platform, replacing the existing button element in the HTML with a container containing one or more child buttons, and modifying the CSS accordingly. Additionally, I also took the opportunity to refactor our custom JS to use modern ES6 constructs (
constandletinstead ofvar,for...ofinstead offor, etc).