This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
PR: Add validation prehooks #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goanpeca
suggested changes
Jan 19, 2017
|
@rlaverde no need to add labels to PRs |
rlaverde
force-pushed
the
pre-validations
branch
2 times, most recently
from
86198de to
1ebc6ba
Compare
|
@goanpeca merge? |
goanpeca
suggested changes
Jan 20, 2017
| import re | ||
| import sys | ||
|
|
||
| PROJECT_REGEX = r'^spyder_[_a-zA-Z0-9]+$' |
There was a problem hiding this comment.
it should be all lowercase, so A-Z is not ok
rlaverde
force-pushed
the
pre-validations
branch
from
1ebc6ba to
dc1e80b
Compare
|
As discussed by chat I only add validation for plugin_name, and I'll open another PR to make other variables invisible. EDIT: Making other variables invisible isn't easy (See: #7) we should validate module name instead |
rlaverde
force-pushed
the
pre-validations
branch
from
dc1e80b to
0580386
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16