-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
@@ -43,11 +43,11 @@ dependencies: | |||
test: | |||
override: | |||
# Check Python style | |||
- $CMD_LINT_CIOCHECK {{ cookiecutter.repo_name }} -dt: # note the colon | |||
- $CMD_LINT_CIOCHECK spyder-{{ cookiecutter.plugin_name.lower().replace(' ', '_') }} -dt: # note the colon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is an error there should be _ not -
parallel: true | ||
|
||
# Run Python tests | ||
- $CMD_TEST_PYTEST {{ cookiecutter.repo_name }} --cov={{ cookiecutter.repo_name }}: # note the colon parallel: true | ||
- $CMD_TEST_PYTEST spyder-{{ cookiecutter.plugin_name.lower().replace(' ', '_') }} --cov=spyder-{{ cookiecutter.plugin_name.lower().replace(' ', '_') }}: # note the colon parallel: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
I'm not sure if this is a good change, directory and file names become really long and ugly .___. I'm closing this, I think that's not to much harm to be asked two more questions, that will be ok to leave with the default value. Maybe we should add a comment in the Readme instead. |
I don't understand how this is a problem? unless it does not work on windows or something is not enough reason |
I address your comments, anyway I dont like to have files named:
and when writing in the terminal with escaping will become:
I think this is so error prone 😕 |
@@ -43,11 +43,11 @@ dependencies: | |||
test: | |||
override: | |||
# Check Python style | |||
- $CMD_LINT_CIOCHECK spyder-{{ cookiecutter.plugin_name.lower().replace(' ', '_') }} -dt: # note the colon | |||
- $CMD_LINT_CIOCHECK spyder-{{ cookiecutter.plugin_name.lower().replace(' ', '-') }} -dt: # note the colon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrong we are calling the module here
parallel: true | ||
|
||
# Run Python tests | ||
- $CMD_TEST_PYTEST spyder-{{ cookiecutter.plugin_name.lower().replace(' ', '_') }} --cov=spyder-{{ cookiecutter.plugin_name.lower().replace(' ', '_') }}: # note the colon parallel: true | ||
- $CMD_TEST_PYTEST spyder-{{ cookiecutter.plugin_name.lower().replace(' ', '-') }} --cov=spyder-{{ cookiecutter.plugin_name.lower().replace(' ', '-') }}: # note the colon parallel: true | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
Closing, I don't like the approach of this PR, I think is better to continue asking for 3 variables. Maybe this change upstream cookiecutter/cookiecutter#364 will make this a lot easier |
Remove
project_name
andrepo_name
, and use insteadplugin_name
modifications.