Use ZMQ sockets to communicate results of pytest run #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should add pyzmq to |
ccordoba12
reviewed
Feb 27, 2018
setup.py
Outdated
| @@ -37,7 +37,7 @@ def get_package_data(name, extlist): | |||
|
|
|||
|
|
|||
| # Requirements | |||
| REQUIREMENTS = ['lxml', 'spyder>=3'] | |||
| REQUIREMENTS = ['lxml', 'spyder>=3', 'zmq'] | |||
There was a problem hiding this comment.
The Python package is called pyzmq, not zmq
ccordoba12
reviewed
Feb 27, 2018
conda.recipe/meta.yaml
Outdated
| @@ -25,6 +25,7 @@ requirements: | |||
| - lxml | |||
| - python | |||
| - spyder >=3 | |||
| - zmq | |||
ccordoba12
reviewed
Feb 27, 2018
circle.yml
Outdated
| @@ -13,14 +13,14 @@ machine: | |||
| COVERALLS_REPO_TOKEN: c5Qt1n27dLFCAIESYVkuCmVpUU8doney1 | |||
| # Environment variables used by astropy helpers | |||
| TRAVIS_OS_NAME: "linux" | |||
| CONDA_DEPENDENCIES: "lxml mock nose pytest" | |||
| CONDA_DEPENDENCIES: "lxml mock nose pytest zmq" | |||
ccordoba12
reviewed
Feb 27, 2018
appveyor.yml
Outdated
| @@ -18,7 +18,7 @@ environment: | |||
| PYTHON_ARCH: "64" # needs to be set for CMD_IN_ENV to succeed. If a mix | |||
| # of 32 bit and 64 bit builds are needed, move this | |||
| # to the matrix section. | |||
| CONDA_DEPENDENCIES: "lxml mock nose pytest spyder" | |||
| CONDA_DEPENDENCIES: "lxml mock nose pytest spyder zmq" | |||
ccordoba12
reviewed
Feb 27, 2018
.travis.yml
Outdated
| @@ -17,7 +17,7 @@ env: | |||
| - TEST_CI="True" | |||
| - TEST_CI_APP="True" | |||
| # Environment variables used by astropy helpers | |||
| - CONDA_DEPENDENCIES="lxml mock nose pytest spyder" | |||
| - CONDA_DEPENDENCIES="lxml mock nose pytest spyder zmq" | |||
|
@ccordoba12 Thanks! Note to self: Always test or suffer embarrassment. |
Jeje, no worries. I'd be drown in brown paper bags for every time I've embarrassed myself in Spyder :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Communicating the results of the pytest run via stdout, as is done now, is fragile. The tests itself may also write to stdout and stderr and it was not clear to me how to block this off completely in complicated cases such as the Spyder tests, where the Qt C library writes to stdout. Communicating over a socket, as implemented here, seems to be more robust. It's also (arguably) cleaner.
Fixes #112.