PR: Delay check whether we are running under pytest until run time

[jitseniesen]

Currently, the test whether the environment variable SPYDER_PYTEST is set (which indicates whether we are running under pytest) is done at import time. However, if the tests are run using the unittest plugin, this import happens before the environment variable is actually set. Thus, this PR delays the test until run time.

With this PR and spyder-ide/spyder-unittest#114, I can run the Spyder test suite successfully within Spyder. 🎉

[pep8speaks]

Hello @jitseniesen! Thanks for updating the PR.

• In the file spyder/app/mainwindow.py, following are the PEP8 issues :

Line 126:1: E402 module level import not at top of file

Comment last updated on February 28, 2018 at 09:58 Hours UTC

[jitseniesen]

The important change is the one at the top of spyder/config/base.py. The other changes are just renames.

I checked the time taken to evaluate running_under_pytest(), because I was afraid that it might be a bottleneck, but it's only one or two microsecond on my laptop.

The PEP8 complaint is not my fault.

[ccordoba12]

Please change this to

from spyder.config.base import (get_conf_path, running_in_mac_app,
                                running_under_pytest)

[ccordoba12]

This is just the way we write multi-line imports in most of our codebase :-)

[ccordoba12]

With this PR and spyder-ide/spyder-unittest#114, I can run the Spyder test suite successfully within Spyder

Really cool! I didn't think this was possible, given the complexity of Spyder's test suite. Thanks a lot for working on this!

I only have one question: any reason to not make this against 3.x? Given that we still have to support that branch, I'd prefer not to deal with two different ways of checking for Pytest in our codebase.

[CAM-Gerlach]

This is trivially minor, but though while PEP 257 allows it, it seems to be convention that we put the summary one-liner on the first line, next to the '''.

[jitseniesen]

Really? I always thought it was the other way around ... I had a quick and random look in our code base. To me, it looks like we have far too few multi-line docstrings and that there is no clear preference for either style. We may need an executive decision here.

[goanpeca]

Hmmm actually I like either

def func():
    """Summary."""

or

def func():
    """
    Summary.

    Something extra.
    """

I don't like this at all :-p

def func():
    """Summary.

    Something extra.
    """

[ccordoba12]

+1 for

def func():
    """
    Summary.

    Some
    """

I like to write docstrings this way too.

[CAM-Gerlach]

I prefer it as well. My concern was only with regard to consistency with the rest of Spyder's codebase, which seemed to mostly use the """Summary line''' form, but I'd be happy to switch.

[jitseniesen]

any reason to not make this against 3.x?

Only that it did not seem necessary to me and that I hadn't tested it. But I just tested it now and it works, so I will change the base.

[ccordoba12]

But I just tested it now and it works, so I will change the base.

Great, thanks!