PR: Add UnittestWorker for tests using unittest #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The downside is that the testing becomes more complicated, because it needs to adjust sys.path before the local imports.
Also use the opportunity to add type annotations.
Instead of parsing the output of unittest, which is supposed to be human reading and thus error prone to parse, run the tests programmatically and send the test results over a separate channel. This mirrors what we do with pytest.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files
|
jitseniesen
force-pushed
the
unittest-worker
branch
from
c97b676
to
3423518
Compare
jitseniesen
force-pushed
the
unittest-worker
branch
from
a8efd5a
to
bf93bfd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of parsing the output of unittest, which is supposed to be human reading and thus error prone to parse, run the tests
programmatically and send the test results over a separate channel. This mirrors what we do with pytest.
Add a test with an example that was parsed incorrectly before and now works.
Fixes #73.
Fixes #76.
Fixes #160.