Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Use Numpy 1.22 because 1.23 is not giving completions #18413

Merged
merged 2 commits into from
Jun 23, 2022

Conversation

ccordoba12
Copy link
Member

Description of Changes

  • Our completion tests for the editor and the console are failing with that version.
  • Also constrain Numpy in our installers in case this problem is not fixed before the next release.

Issue(s) Resolved

Fixes #18407.

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12 ccordoba12 added this to the v5.3.2 milestone Jun 23, 2022
@ccordoba12 ccordoba12 requested a review from dalthviz June 23, 2022 16:43
@ccordoba12 ccordoba12 self-assigned this Jun 23, 2022
@ccordoba12 ccordoba12 force-pushed the issue-18407 branch 3 times, most recently from 3e296ca to 5c45c26 Compare June 23, 2022 17:13
Copy link
Member

@dalthviz dalthviz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ccordoba12 !

@dalthviz dalthviz merged commit 5f271fc into spyder-ide:5.x Jun 23, 2022
dalthviz added a commit that referenced this pull request Jun 23, 2022
@ccordoba12 ccordoba12 deleted the issue-18407 branch June 23, 2022 20:21
@dalthviz dalthviz mentioned this pull request Jul 1, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants