Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Use Numpy 1.22 because 1.23 is not giving completions #18413

Merged
merged 2 commits into from
Jun 23, 2022
Merged

PR: Use Numpy 1.22 because 1.23 is not giving completions #18413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82fb64a
Testing: Use Numpy 1.22 because 1.23 is not giving completions
ccordoba12 Jun 23, 2022
9b6db78
Constrain Numpy to be less than 1.23 in our installers
ccordoba12 Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/scripts/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ if [ "$USE_CONDA" = "true" ]; then

# To check our manifest and coverage
mamba install check-manifest codecov -c conda-forge -q -y

# Numpy 1.23 is not giving completions on the editor and the console
if [ "$OS" = "win" ]; then
mamba install numpy=1.22
else
mamba install 'numpy<1.23'
fi
else
# Update pip and setuptools
python -m pip install -U pip setuptools wheel build
Expand All @@ -37,6 +44,9 @@ else
# To check our manifest and coverage
pip install -q check-manifest codecov

# Numpy 1.23 is not giving completions on the editor and the console
pip install 'numpy<1.23'

# This allows the test suite to run more reliably on Linux
if [ "$OS" = "linux" ]; then
pip uninstall pyqt5 pyqt5-qt5 pyqt5-sip pyqtwebengine pyqtwebengine-qt5 -q -y
Expand Down
2 changes: 1 addition & 1 deletion installers/Windows/req-extras-pull-request.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ rope
yapf

# Scientific packages (for Same as Spyder)
numpy
numpy<1.23
scipy
pandas
openpyxl # pandas optional dependency to handle Excel files
Expand Down
2 changes: 1 addition & 1 deletion installers/Windows/req-extras-release.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ rope
yapf

# Scientific packages (for Same as Spyder)
numpy
numpy<1.23
scipy
pandas
openpyxl # pandas optional dependency to handle Excel files
Expand Down
2 changes: 1 addition & 1 deletion installers/macOS/req-scientific.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Scientific packages (for Same as Spyder)
cython
matplotlib
numpy
numpy<1.23
openpyxl
pandas
scipy
Expand Down