Render if_not_exists option for CreateTableOp, CreateIndexOp, DropTableOp and DropIndexOp

[lachaib]

Related: #151

Description

Without opinion on whether or not the option if_not_exists or if_exists should be set by default (or configurable via AutogenContext), I think a follow-up on
#151 should be that if_not_exists or if_exists attributes should be that they are rendered during autogen steps.

How I intend to use it: specify the attribute during rewrites of the pipeline

@writer.rewrites(ops.CreateIndexOp)
def create_index_if_not_exist(_autogen_context, _revision, op: ops.CreateIndexOp):
    op.if_not_exists = True
    return op


@writer.rewrites(ops.DropIndexOp)
def drop_index_if_exist(_autogen_context, _revision, op: ops.DropIndexOp):
    op.if_exists = True
    return op

Checklist

This pull request is:

• A documentation / typographical error fix
  • Good to go, no issue or tests are needed
• A short code fix
  • please include the issue number, and create an issue if none exists, which
    must include a complete example of the issue. one line code fixes without an
    issue and demonstration will not be accepted.
  • Please include: Fixes: #<issue number> in the commit message
  • please include tests. one line code fixes without tests will not be accepted.
• A new feature implementation
  • please include the issue number, and create an issue if none exists, which must
    include a complete example of how the feature would look.
  • Please include: Fixes: #<issue number> in the commit message
  • please include tests.

Have a nice day!

[CaselIT]

sorry I kinda lost this PR.

configurable via AutogenContext

It may make sense. @zzzeek what do you think about adding an option to control this?

It's missing a changelog. see example in https://github.com/sqlalchemy/alembic/tree/main/docs/build/unreleased

Feel free to add something like "pull request courtesy of "

[lachaib]

Hi @CaselIT, thanks for the review. I rebased upon main branch & added a changelog entry. Feel free to tell me how in any way I can now help this pull request move forward.

[CaselIT]

Let's wait on mike's opinion on the flag(s) in autogenerate

[sqla-tester]

OK, this is sqla-tester setting up my work on behalf of CaselIT to try to get revision 7ddeaab of this pull request into gerrit so we can run tests and reviews and stuff

[sqla-tester]

New Gerrit review created for change 7ddeaab: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5454

[sqla-tester]

Hi, this is sqla-tester and I see you've pinged me for review. However, user lachaib is not authorized to initiate CI jobs. Please wait for a project member to do this!

[zzzeek]

hi!

sorry didnt see this.

Turns out we are also getting ready to merge the same option for tables in #1521.

So I want to get #1521 merged and then we can update this to support autogen for both index and table, hows that?

I understand this got ignored for 6 months so if you aren't around I'll just pull this in and finish it up.

[sqla-tester]

OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision cb57978 of this pull request into gerrit so we can run tests and reviews and stuff

[sqla-tester]

Patchset cb57978 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5454

[lachaib]

Ok ping me when the other PR is merged and I'll take care.

[sqla-tester]

Michael Bayer (zzzeek) wrote:

OK this is ready for adding if_exists / if_not_exists rendering support for create_table and drop_table also

View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5454

[lachaib]

I've seen the PR merged, gonna take care of this over the weekend

[CaselIT]

Thanks!

[lachaib]

@zzzeek @CaselIT I proudly present the updated PR with render as well on tables 😁

[lachaib]

@zzzeek @CaselIT , any chance this PR may get merged soon? I have incoming works regarding our migrations and I'd be delighted to include a new alembic along the way

[zzzeek]

sorry I get no notification that anything changed here, will run it through now

[sqla-tester]

OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 90c9735 of this pull request into gerrit so we can run tests and reviews and stuff

[sqla-tester]

Patchset 90c9735 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5454

[sqla-tester]

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5454 has been merged. Congratulations! :)

[zzzeek]

alembic 1.13.3 is released now with this change