Support if_exists and if_not_exists on create/drop table commands #1521

agriffin-grow · 2024-08-14T21:58:52Z

Fixes: #1520

Description

Adds if_exists/if_not_exists support to table commands, mirroring closely the same logic for indexes.

Checklist

This pull request is:

A documentation / typographical error fix
- Good to go, no issue or tests are needed
A short code fix
- please include the issue number, and create an issue if none exists, which
  must include a complete example of the issue. one line code fixes without an
  issue and demonstration will not be accepted.
- Please include: Fixes: #<issue number> in the commit message
- please include tests. one line code fixes without tests will not be accepted.
A new feature implementation
- please include the issue number, and create an issue if none exists, which must
  include a complete example of how the feature would look.
- Please include: Fixes: #<issue number> in the commit message
- please include tests.

Have a nice day!

agriffin-grow · 2024-08-14T21:59:49Z

alembic/operations/base.py

+            :param if_not_exists: If True, adds IF NOT EXISTS operator when
+             creating the table.
+
+             .. versionadded:: 1.13.4


Not really sure if this is the correct next version. Happy to change it.

it would be 1.13.3 since it's yet to be released

CaselIT

great work. It's just missing a changelog: see example in https://github.com/sqlalchemy/alembic/tree/main/docs/build/unreleased

Feel free to add something like "pull request courtesy of "

sorry for the delay in the review

CaselIT · 2024-08-27T18:48:35Z

alembic/operations/base.py

+            :param if_not_exists: If True, adds IF NOT EXISTS operator when
+             creating the table.
+
+             .. versionadded:: 1.13.4


it would be 1.13.3 since it's yet to be released

lachaib · 2024-08-28T05:41:31Z

Hello,

My 2 cents on this PR, which I'm looking forward, is that it's missing the same thing I'm trying to fix with #1446 : we should have a small addition in alembic/autogenerate/render.py to render the option from autogen context.
It'd be great to have it from the start.

Thanks a lot for this pull request

sqla-tester

OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 88c7b3f of this pull request into gerrit so we can run tests and reviews and stuff

sqla-tester · 2024-08-28T14:18:17Z

New Gerrit review created for change 88c7b3f: https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5455

zzzeek

the tools/write_pyi.py script needs to be run here to generate appropriate stub files

agriffin-grow · 2024-08-28T21:46:46Z

@CaselIT @zzzeek updated based on your comments.

I also bumped against #1524 when using tools/write_pyi.py and put in a PR for that.

sqla-tester

OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 1063a5a of this pull request into gerrit so we can run tests and reviews and stuff

sqla-tester · 2024-08-31T14:59:39Z

Patchset 1063a5a added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5455

zzzeek · 2024-09-01T20:32:55Z

hi -

still some failures here you may need to add skip markers to these tests for SQLAlchemy < 1.4

agriffin-grow · 2024-09-03T14:38:29Z

hi -

still some failures here you may need to add skip markers to these tests for SQLAlchemy < 1.4

TY, I missed that tests still run for sqlalchemy 1.3 - should be updated now

sqla-tester

OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 747ae3f of this pull request into gerrit so we can run tests and reviews and stuff

sqla-tester · 2024-09-03T15:36:41Z

Patchset 747ae3f added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5455

sqla-tester · 2024-09-03T16:42:24Z

Michael Bayer (zzzeek) wrote:

recheck

View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5455

sqla-tester

Michael Bayer (zzzeek) wrote:

code review left on gerrit

View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5455

tox.ini

sqla-tester

OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision ab4e7d4 of this pull request into gerrit so we can run tests and reviews and stuff

sqla-tester · 2024-09-04T14:45:18Z

Patchset ab4e7d4 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5455

sqla-tester

OK, this is sqla-tester setting up my work on behalf of zzzeek to try to get revision 469be01 of this pull request into gerrit so we can run tests and reviews and stuff

sqla-tester · 2024-09-10T14:36:13Z

Patchset 469be01 added to existing Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5455

sqla-tester

Michael Bayer (zzzeek) wrote:

code review left on gerrit

View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5455

tox.ini (line 8): Done

sqla-tester · 2024-09-11T16:59:35Z

Federico Caselli (CaselIT) wrote:

Great work!

View this in Gerrit at https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5455

agriffin-grow · 2024-09-11T21:54:01Z

FYI I think @zzzeek might need to approve as well on account of the requested changes... but I also have no idea how Github and Gerrit interact with each other :)

sqla-tester · 2024-09-13T17:24:40Z

Gerrit review https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/5455 has been merged. Congratulations! :)

Support if_exists and if_not_exists on create/drop table commands

88c7b3f

agriffin-grow mentioned this pull request Aug 14, 2024

Support if_exists / if_not_exists on drop_table and create_table operations #1520

Closed

agriffin-grow commented Aug 14, 2024

View reviewed changes

CaselIT approved these changes Aug 27, 2024

View reviewed changes

zzzeek requested a review from sqla-tester August 28, 2024 14:18

sqla-tester reviewed Aug 28, 2024

View reviewed changes

zzzeek requested changes Aug 28, 2024

View reviewed changes

zzzeek mentioned this pull request Aug 28, 2024

Render if_not_exists option for CreateTableOp, CreateIndexOp, DropTableOp and DropIndexOp #1446

Closed

3 tasks

agriffin-grow added 2 commits August 28, 2024 16:35

Switch version in comments, add changelog

60053bc

Run write_pyi

1063a5a

zzzeek requested a review from sqla-tester August 31, 2024 14:59

sqla-tester reviewed Aug 31, 2024

View reviewed changes

Add sqlalchemy 1.4 requirement to tests

747ae3f

zzzeek requested a review from sqla-tester September 3, 2024 15:36

sqla-tester reviewed Sep 3, 2024

View reviewed changes

tox.ini Outdated Show resolved Hide resolved

Revert tox.ini changes

ab4e7d4

zzzeek requested a review from sqla-tester September 4, 2024 14:45

sqla-tester reviewed Sep 4, 2024

View reviewed changes

Fix documentation

469be01

zzzeek requested a review from sqla-tester September 10, 2024 14:36

sqla-tester reviewed Sep 10, 2024

View reviewed changes

sqla-tester reviewed Sep 11, 2024

View reviewed changes

sqlalchemy-bot closed this in 8fae3e1 Sep 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support if_exists and if_not_exists on create/drop table commands #1521

Support if_exists and if_not_exists on create/drop table commands #1521

agriffin-grow commented Aug 14, 2024

agriffin-grow Aug 14, 2024

CaselIT Aug 27, 2024

CaselIT left a comment

CaselIT Aug 27, 2024

lachaib commented Aug 28, 2024

sqla-tester left a comment

sqla-tester commented Aug 28, 2024

zzzeek left a comment

agriffin-grow commented Aug 28, 2024

sqla-tester left a comment

sqla-tester commented Aug 31, 2024

zzzeek commented Sep 1, 2024

agriffin-grow commented Sep 3, 2024

sqla-tester left a comment

sqla-tester commented Sep 3, 2024

sqla-tester commented Sep 3, 2024

sqla-tester left a comment

sqla-tester left a comment

sqla-tester commented Sep 4, 2024

sqla-tester left a comment

sqla-tester commented Sep 10, 2024

sqla-tester left a comment

sqla-tester commented Sep 11, 2024

agriffin-grow commented Sep 11, 2024

sqla-tester commented Sep 13, 2024

Support if_exists and if_not_exists on create/drop table commands #1521

Support if_exists and if_not_exists on create/drop table commands #1521

Conversation

agriffin-grow commented Aug 14, 2024

Description

Checklist

agriffin-grow Aug 14, 2024

Choose a reason for hiding this comment

CaselIT Aug 27, 2024

Choose a reason for hiding this comment

CaselIT left a comment

Choose a reason for hiding this comment

CaselIT Aug 27, 2024

Choose a reason for hiding this comment

lachaib commented Aug 28, 2024

sqla-tester left a comment

Choose a reason for hiding this comment

sqla-tester commented Aug 28, 2024

zzzeek left a comment

Choose a reason for hiding this comment

agriffin-grow commented Aug 28, 2024

sqla-tester left a comment

Choose a reason for hiding this comment

sqla-tester commented Aug 31, 2024

zzzeek commented Sep 1, 2024

agriffin-grow commented Sep 3, 2024

sqla-tester left a comment

Choose a reason for hiding this comment

sqla-tester commented Sep 3, 2024

sqla-tester commented Sep 3, 2024

sqla-tester left a comment

Choose a reason for hiding this comment

sqla-tester left a comment

Choose a reason for hiding this comment

sqla-tester commented Sep 4, 2024

sqla-tester left a comment

Choose a reason for hiding this comment

sqla-tester commented Sep 10, 2024

sqla-tester left a comment

Choose a reason for hiding this comment

sqla-tester commented Sep 11, 2024

agriffin-grow commented Sep 11, 2024

sqla-tester commented Sep 13, 2024