Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Drobe-available items to Loadouts -- red bandana for SecOff, brown bandana for CargoTech, noir coat for Det #73

Merged
merged 5 commits into from
Sep 23, 2024

Conversation

FluffMe
Copy link
Collaborator

@FluffMe FluffMe commented Sep 22, 2024

About the PR

  • Remove misspelled and unused folder Loadlouts from Harmony namespace.
  • Add "brown bandana" to Cargo Tech loadout.
  • Add "red bandana" to Security Officer loadout.
  • Add "noir trenchcoat" to Detective loadout.

Why / Balance

All three items are readily available at respective departments' Drobes.
Requested by players to streamline their preferred character look round start.

Technical details

Harmony namespace

  • Resources/Prototypes/Harmony/Loadlouts/* removed. Misspelled, and contains only commented out files. @KelfWolf, please check.
  • Resources/Prototypes/Harmony/Loadouts/Jobs/Cargo/cargo_technician.yml -- new loadout options.
  • Resources/Prototypes/Harmony/Loadouts/Jobs/Security/detective.yml -- new loadout options.
  • Resources/Prototypes/Harmony/Loadouts/Jobs/Security/security_officer.yml -- new loadout options.

Upstream modifications

  • Resources/Prototypes/Loadouts/loadout_groups.yml -- introduces the options above to loadout groups. Properly commented.

Media

image
image
image

Requirements

Changelog
🆑

  • add: Added "brown bandana" as a headwear option for Cargo Tech loadout.
  • add: Added "red bandana" as a headwear option for Security Officer loadout.
  • add: Added "noir trenchcoat" as a outer clothing option for Detective loadout.

@FluffMe
Copy link
Collaborator Author

FluffMe commented Sep 22, 2024

@KeldWolf this modifies your previous work on pins, so please take a closer look at what I am deleting.

@FluffMe FluffMe requested a review from KeldWolf September 22, 2024 14:04
@github-actions github-actions bot added the S: Needs Review Review is requested label Sep 22, 2024
@FluffMe FluffMe marked this pull request as draft September 22, 2024 16:06
@FluffMe
Copy link
Collaborator Author

FluffMe commented Sep 22, 2024

Waiting for space-wizards#32380 resolution before merging.

Copy link

@KeldWolf KeldWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good to see that stuff getting cleaned up. The changes are good. I like the "drobes" being a place to get other stuff during the round. But, loadouts are really where folks express themselves and I'm all for more options there.

@KeldWolf KeldWolf marked this pull request as ready for review September 23, 2024 15:42
Copy link

@KeldWolf KeldWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to approve =D

@KeldWolf KeldWolf merged commit d695cbd into master Sep 23, 2024
23 checks passed
@FluffMe FluffMe deleted the adjust-loadouts branch September 23, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants