add rollout.Spec.Strategy.Canary.MinPodsPerRS #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore switching traffic (argoproj#1663) Signed-off-by: khhirani <kareena.hirani@gmail.com>
…goproj#1646) Signed-off-by: khhirani <kareena.hirani@gmail.com>
Signed-off-by: khhirani <kareena.hirani@gmail.com>
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
) fix: reset the progress condition when a pod is restarted (argoproj#1649) Signed-off-by: Hui Kang <hui.kang@salesforce.com> Co-authored-by: Hui Kang <hui.kang@salesforce.com> Co-authored-by: Rohit Agrawal <rohit.agrawal@databricks.com>
* docs: Add link to awesome-argo for more resources Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> * Retrigger CI pipeline Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Siddharth Maloo <smaloo@salesforce.com>
* fix: sending updates to dashboard when a pod terminates Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com> * Fix imports Signed-off-by: Andrii Perenesenko <andrii.perenesenko@gmail.com>
dryRun can be used on a metric to control whether or not to evaluate that metric in a dry-run mode. A metric running in the dry-run mode won't impact the final state of the rollout or experiment even if it fails or the evaluation comes out as inconclusive. Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
…1674) Signed-off-by: Hui Kang <hui.kang@salesforce.com> Co-authored-by: Rohit Agrawal <rohit.agrawal@databricks.com>
…argoproj#1679) Signed-off-by: Jesse Suen <jesse@akuity.io>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
…in go 1.17 (argoproj#1692) * chore: pin sys module to resolve a fatal runtime execution in go 1.17 Signed-off-by: Hui Kang <hui.kang@salesforce.com> * go mod tidy Signed-off-by: Hui Kang <hui.kang@salesforce.com>
Signed-off-by: Jesse Suen <jesse@akuity.io>
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
…#1710) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
…j#1572 (argoproj#1577) * fix: use patch to update workload-generation annotation Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> * Add support for AWS ALB TargetGroupStickinessConfig Adds support for AWS ALB [TargetGroupStickinessConfig](https://aws.amazon.com/blogs/aws/new-application-load-balancer-simplifies-deployment-with-weighted-target-groups/) This is required to support sticky session on the listener level while Argo is using ALB's weighting Signed-off-by: Sebastian J <zeeman@zeeman.de> * Remove code smells Signed-off-by: Sebastian J <zeeman@zeeman.de> * more code smells Signed-off-by: Sebastian J <zeeman@zeeman.de> * PR feedback Signed-off-by: Sebastian J <zeeman@zeeman.de> * Revert Signed-off-by: Sebastian J <zeeman@zeeman.de> * Another test round Signed-off-by: Sebastian J <zeeman@zeeman.de> * Force codegen GO 1.16 Forced codegen via downgrading to Go 1.16: ``` $ env|grep GO GOPATH=/Users/sebastian/go ``` ``` $ go version go version go1.16.10 darwin/amd64 ``` ``` $ echo $PATH /Users/sebastian/.sdkman/candidates/micronaut/current/bin:/Users/sebastian/.sdkman/candidates/java/current/bin:/Users/sebastian/.cargo/bin:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/Library/TeX/texbin:/usr/local/MacGPG2/bin:/usr/local/share/dotnet:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/bin:/Users/sebastian/go/bin ``` Signed-off-by: Sebastian J <zeeman@zeeman.de> * Added documentaiton Signed-off-by: Sebastian J <zeeman@zeeman.de> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>
Signed-off-by: Piyush Baderia <piyush.baderia@outlook.com>
…ments (argoproj#1691) Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>
argoproj#1603) Bumps [github.com/evanphx/json-patch/v5](https://github.com/evanphx/json-patch) from 5.2.0 to 5.6.0. - [Release notes](https://github.com/evanphx/json-patch/releases) - [Commits](evanphx/json-patch@v5.2.0...v5.6.0) --- updated-dependencies: - dependency-name: github.com/evanphx/json-patch/v5 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…j#1508) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 2.0.3 to 2.1.0. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-action@v2.0.3...v2.1.0) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
fix: Enable default triggers for argo rollouts (argoproj#1689) Signed-off-by: Ravi Hari <ravireliable@gmail.com>
…rgoproj#1717) Signed-off-by: Hui Kang <hui.kang@salesforce.com>
- keep promote and abort buttons enabled while deploying - disable them at all other times - also, only enable retry button when Rollout is degraded Fixes argoproj#1581 Signed-off-by: Ben Poland <ben.poland@faire.com>
argoproj#1902) Signed-off-by: Simon Ninon <sninon@pagerduty.com>
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: Martin Adler <1208749+EagleIJoe@users.noreply.github.com>
…j#1986) * fix: make sure we update rollout.Status.ALB when first create Rollout object This fixes the case when we first create a rollout the status.ALB field does not get updated with valid information form the elb. Signed-off-by: zachaller <zachaller@hotmail.com> * Refactor check for if we should verify alb. This creates a new rolloututil function ShouldVerifyWeight that verifies that we should call aws because the rollout is in the middle of some update. The reason I feel this should move into the ingress implmentation function VerifyWeight is becuase in the future other ingresses might also need to verify weights and adding ingress specific status checks in trafficrouting.go like a leak details where it should be up to the ingress provider to determin if it should be careful of rate limiting do to say it being a cloud provider call. Signed-off-by: zachaller <zachaller@hotmail.com> * lint Signed-off-by: zachaller <zachaller@hotmail.com> * Fix tests Signed-off-by: zachaller <zachaller@hotmail.com> * Add new test for ShouldVerifyWeight Signed-off-by: zachaller <zachaller@hotmail.com> * Fix logic Signed-off-by: zachaller <zachaller@hotmail.com> * Add test for where we do not need to verify weight and its already set Signed-off-by: zachaller <zachaller@hotmail.com> * fix up review comments Signed-off-by: zachaller <zachaller@hotmail.com> * fix tests Signed-off-by: zachaller <zachaller@hotmail.com> * fix bad merge Signed-off-by: zachaller <zachaller@hotmail.com> * Fix test Signed-off-by: zachaller <zachaller@hotmail.com> * Fix test Signed-off-by: zachaller <zachaller@hotmail.com> * Clearer function name Signed-off-by: zachaller <zachaller@hotmail.com> * Clean up if logic Signed-off-by: zachaller <zachaller@hotmail.com>
…build up (argoproj#2115) * fix: remove metrics on resource removal Signed-off-by: zachaller <zachaller@hotmail.com> * Add test Signed-off-by: zachaller <zachaller@hotmail.com> * More tests Signed-off-by: zachaller <zachaller@hotmail.com> * back off deps updates Signed-off-by: zachaller <zachaller@hotmail.com> * Fix dep change Signed-off-by: zachaller <zachaller@hotmail.com> * upgrade prom deps for new features Signed-off-by: zachaller <zachaller@hotmail.com> * fix deps Signed-off-by: zachaller <zachaller@hotmail.com>
…j#2148) Signed-off-by: zachaller <zachaller@hotmail.com>
…goproj#2131) Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Signed-off-by: Leonardo Luz Almeida <leonardo_almeida@intuit.com>
…oproj#2102. (argoproj#2094) * Graphite metrics provider linked in docs sidebar This fixes an issue wherein the Graphite metrics provider has no sidebar link in the docs hosted at https://argoproj.github.io/argo-rollouts/. As a bonus, this also removes various trailing whitespace from analysis docs. Signed-off-by: Mike Ball <mikedball@gmail.com> * build trigger Signed-off-by: Mike Ball <mikedball@gmail.com>
Signed-off-by: Hui Kang <hui.kang@salesforce.com> Co-authored-by: Hui Kang <hui.kang@salesforce.com>
* Upgrade golang Signed-off-by: zachaller <zachaller@hotmail.com> * upgrade golang to 1.18 for e2e Signed-off-by: zachaller <zachaller@hotmail.com> * Fix deps Signed-off-by: zachaller <zachaller@hotmail.com> * Update build action Signed-off-by: zachaller <zachaller@hotmail.com> * Upgrade push action Signed-off-by: zachaller <zachaller@hotmail.com> * Update docker file Signed-off-by: zachaller <zachaller@hotmail.com> * Bump golang lint to match Signed-off-by: zachaller <zachaller@hotmail.com> * fix go.mod Signed-off-by: zachaller <zachaller@hotmail.com>
…uts notification (argoproj#2150) * fix: update rolloutobject with gvk before writing to rollout informer Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: controller schema linting Signed-off-by: Ravi Hari <ravireliable@gmail.com> * docs: comment the details on the change Signed-off-by: Ravi Hari <ravireliable@gmail.com> * docs: comment the details on the change Signed-off-by: Ravi Hari <ravireliable@gmail.com>
…proj#2198) * fix: rootPath support so that it uses the embeded files system Signed-off-by: zachaller <zachaller@hotmail.com> * Catch edge cases and make sure we always server index.html on not found Signed-off-by: zachaller <zachaller@hotmail.com> * turn path.Clean into var Signed-off-by: zachaller <zachaller@hotmail.com> Signed-off-by: zachaller <zachaller@hotmail.com>
…es also adds an event for when it does changes. (argoproj#2203) * feat: add healthy event/condition and fix completed event/condition Signed-off-by: zachaller <zachaller@hotmail.com> * fix unit tests Signed-off-by: zachaller <zachaller@hotmail.com> * rename vars to make more sense and remove healthy event becase it will never be consistent Signed-off-by: zachaller <zachaller@hotmail.com> * fix unit tests Signed-off-by: zachaller <zachaller@hotmail.com> * possible fix for e2e Signed-off-by: zachaller <zachaller@hotmail.com> * fix e2e Signed-off-by: zachaller <zachaller@hotmail.com> * unit test for complete function Signed-off-by: zachaller <zachaller@hotmail.com> * small cleanup and changes to not check generation Signed-off-by: zachaller <zachaller@hotmail.com> * fix unit test and proper behavior Signed-off-by: zachaller <zachaller@hotmail.com> * Fix e2e Signed-off-by: zachaller <zachaller@hotmail.com> * rename and fix one unit test Signed-off-by: zachaller <zachaller@hotmail.com> * fix unit tests Signed-off-by: zachaller <zachaller@hotmail.com> * fix unit test Signed-off-by: zachaller <zachaller@hotmail.com> * add seperate test for TestRolloutComplete Signed-off-by: zachaller <zachaller@hotmail.com> * renames Signed-off-by: zachaller <zachaller@hotmail.com> * fix e2e Signed-off-by: zachaller <zachaller@hotmail.com> * Set Completed to false Signed-off-by: zachaller <zachaller@hotmail.com> * Add event Signed-off-by: zachaller <zachaller@hotmail.com> * fix e2e Signed-off-by: zachaller <zachaller@hotmail.com> * refactor Signed-off-by: zachaller <zachaller@hotmail.com> * Fix all but one unit test Signed-off-by: zachaller <zachaller@hotmail.com> * fix last unit test Signed-off-by: zachaller <zachaller@hotmail.com> * lint Signed-off-by: zachaller <zachaller@hotmail.com> * cleanup Signed-off-by: zachaller <zachaller@hotmail.com> * Rename Signed-off-by: zachaller <zachaller@hotmail.com> * More renames Signed-off-by: zachaller <zachaller@hotmail.com> * small comment change Signed-off-by: zachaller <zachaller@hotmail.com> Signed-off-by: zachaller <zachaller@hotmail.com>
This change adds support for `spec.ingressClassName` while still supporting `kubernetes.io/ingress.class` annotation for backwards compatibility. Fixes argoproj#1277 Signed-off-by: Siavash Safi <git@hosted.run> Signed-off-by: Siavash Safi <git@hosted.run>
* fix: Add pagination to FindLoadBalancerByDNSName (argoproj#1971) * fix: this close issue argoproj#1963 by adding pagination to FindLoadBalancerByDNSName This adds pagination to the FindLoadBalancerByDNSName function this should allow argo rollouts to work with any number of loadbalancers. Signed-off-by: zachaller <zachaller@hotmail.com> * fix: missing lb event (argoproj#2021) * fix: turn missing load balancer log into an event Signed-off-by: zachaller <zachaller@hotmail.com> * consistent naming Signed-off-by: zachaller <zachaller@hotmail.com> * fix: Use actual weight from status field on rollout object (argoproj#1937) fix: Use actual weight from status field on rollout object (argoproj#1937) Signed-off-by: zachaller <zachaller@hotmail.com> * fix: build/lint is broken due to dependencies changes (argoproj#1958) Signed-off-by: zachaller <zachaller@hotmail.com> * following github workflow error prompt to fix Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com> * go fmt Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com> * make go-mod-vendor Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com> * fix path Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com> Signed-off-by: zachaller <zachaller@hotmail.com> Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com> Co-authored-by: Zach Aller <zachaller@users.noreply.github.com> Co-authored-by: Travis Perdue <travis.perdue@rallyhealth.com>
Signed-off-by: Shlomo Sanders <ssanders@synamedia.com>
* fix: enable notifications without when condition Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: use trigger action item from the list Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: add emptycondition logic to make notifications work with/without conditions Signed-off-by: Ravi Hari <ravireliable@gmail.com> * fix: linting Signed-off-by: Ravi Hari <ravireliable@gmail.com> Signed-off-by: Ravi Hari <ravireliable@gmail.com>
Signed-off-by: zachaller <zachaller@hotmail.com> Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: zachaller <zachaller@hotmail.com> Signed-off-by: zachaller <zachaller@hotmail.com>
…roj#2256) * fix: nil pointer while linting basic canary with Ingress resources Signed-off-by: zachaller <zachaller@hotmail.com> * Add test case Signed-off-by: zachaller <zachaller@hotmail.com> Signed-off-by: zachaller <zachaller@hotmail.com>
…#2139 (argoproj#2261) * Add roundtripper to kubeconfig before creating kubeclient Signed-off-by: Nikhil <nikhil1.raghav@gmail.com> * Check if k8sRequestsCount is nil before attempting increase Signed-off-by: Nikhil <nikhil1.raghav@gmail.com> * Added Flipkart to Users.md Signed-off-by: Nikhil <nikhil1.raghav@gmail.com> * gofmt controller/metrics/client.go Signed-off-by: Nikhil <nikhil1.raghav@gmail.com> Signed-off-by: Nikhil <nikhil1.raghav@gmail.com>
…j#2268) * fixes argoproj#2266 Signed-off-by: zachaller <zachaller@users.noreply.github.com> * typo Signed-off-by: zachaller <zachaller@users.noreply.github.com> * test after calling set mirror Signed-off-by: zachaller <zachaller@users.noreply.github.com> * Keep port on user defined service by adding to internal types Signed-off-by: zachaller <zachaller@users.noreply.github.com> * github trigger re-run Signed-off-by: zachaller <zachaller@users.noreply.github.com> * Drop port on virtual service to be consistent with added routes Drop the port on the virtual service with the statment that rollouts only supports one port services. Signed-off-by: zachaller <zachaller@users.noreply.github.com> * cleanup test to just test extra fields and add a port check on destination as well Signed-off-by: zachaller <zachaller@users.noreply.github.com> * keep port for both mirroring and header routes Signed-off-by: zachaller <zachaller@users.noreply.github.com> * github trigger re-run Signed-off-by: zachaller <zachaller@users.noreply.github.com> * github trigger re-run Signed-off-by: zachaller <zachaller@users.noreply.github.com> * add function comment Signed-off-by: zachaller <zachaller@users.noreply.github.com> Signed-off-by: zachaller <zachaller@users.noreply.github.com>
cherry-picked commit 4848fb1 from master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.