Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return error message if run fails #43

Closed
EdGreen21 opened this issue Oct 23, 2024 · 0 comments · Fixed by #46
Closed

return error message if run fails #43

EdGreen21 opened this issue Oct 23, 2024 · 0 comments · Fixed by #46

Comments

@EdGreen21
Copy link
Collaborator

rather than return blank *.csv, either

  1. Return a standard text file suggesting that the user read the manual and try again
  2. Preferred: return the error message and a standard text
lkeegan added a commit that referenced this issue Oct 28, 2024
@lkeegan
Implement upload of results
410d730 
- runner creates two folders and uploads them as zipfiles
  - `/user_results`: provided to user
  - `/trusted_user_results`: provided to user if they have "full results" enabled by an admin
  - `/admin_results`: only visible to admins
- admin results are always uploaded, included for failed runs (for debugging)
- user results are only provided if the run was successful
- add `PREDICTCR_RUNNER_SCRIPT_DIR` env var to docker compose to specify where script & model can be found
- add /admin/result endpoint to download admin results zipfile
- switch from micromamba to miniconda docker image
  - reticulate doesn't seem to support micromamba, at least within docker
- re-enable runner docker image CI
- update runner README.md
- resolves #6
- resolves #43

Also refactor admin views using tabs
lkeegan added a commit that referenced this issue Oct 28, 2024
@lkeegan
Implement upload of results
c89c528 
- runner creates three folders where the script runs, and uploads their contents as zipfiles:
  - `/user_results`: provided to user
  - `/trusted_user_results`: provided to user if they have "full results" enabled by an admin
  - `/admin_results`: only visible to admins
- admin results are always uploaded, included for failed runs (for debugging)
- user results are only provided if the run was successful
- add `PREDICTCR_RUNNER_SCRIPT_DIR` env var to docker compose to specify where script & model can be found
- add /admin/result endpoint to download admin results zipfile
- switch from micromamba to miniconda docker image
  - reticulate doesn't seem to support micromamba, at least within docker
- re-enable runner docker image CI
- update runner README.md
- resolves #6
- resolves #43

Also refactor admin views using tabs
@lkeegan lkeegan mentioned this issue Oct 28, 2024
Merged
lkeegan added a commit that referenced this issue Oct 28, 2024
@lkeegan
Implement upload of results
2e48216 
- runner creates three folders where the script runs, and uploads their contents as zipfiles:
  - `/user_results`: provided to user
  - `/trusted_user_results`: provided to user if they have "full results" enabled by an admin
  - `/admin_results`: only visible to admins
- admin results are always uploaded, included for failed runs (for debugging)
- user results are only provided if the run was successful
- add `PREDICTCR_RUNNER_SCRIPT_DIR` env var to docker compose to specify where script & model can be found
- add /admin/result endpoint to download admin results zipfile
- switch from micromamba to miniconda docker image
  - reticulate doesn't seem to support micromamba, at least within docker
- re-enable runner docker image CI
- update runner README.md
- resolves #6
- resolves #43

Also refactor admin views using tabs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement upload of results ssciwr/predicTCR
1 participant
@EdGreen21