Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

results upload #6

Closed
lkeegan opened this issue Sep 9, 2024 · 3 comments · Fixed by #46
Closed

results upload #6

lkeegan opened this issue Sep 9, 2024 · 3 comments · Fixed by #46
Labels
enhancement New feature or request

Comments

@lkeegan
Copy link
Member

lkeegan commented Sep 9, 2024

results from runner analysis script will be:

  • csv file
  • breakpoint between reactive/non-reactive rows in csv file
  • visualisation of results
    • todo: this could either be
      • generated as png/svg by the script (easier to modify in the future)
      • or the website could generate the visualization from the results directly
@lkeegan lkeegan added the enhancement New feature or request label Sep 9, 2024
@EdGreen21
Copy link
Collaborator

this is an interesting one... we could actually use the results to connect to other tools we have developed to clone TCRs... i.e. go from sequence on the screen to DNA in a tube. These are also implemented in R, though a key part might run better in python... I'll think about this

@EdGreen21
Copy link
Collaborator

if we get the TCR manufacturing paper out, then we could use this to drive academic interest towards our solution

@lkeegan
Copy link
Member Author

lkeegan commented Oct 25, 2024

Following today's discussion on uploading the results:

  • the script

    • takes a full_results argument that specifies if the user should get partial or full results
    • puts generated result files into two folders:
      • user_results/
        • these files will be provided to the user from the website as a zipfile to download
      • admin_results/
        • these files will only be accessible by admins (also as a zip file)
        • should also contain logs for debugging failed runs
  • the runner

    • passes the full_results argument to the script
    • zips & uploads the contents of the user_results folder for web access by the user
    • zips & uploads the contents of the admin_results folder for web access by admins

lkeegan added a commit that referenced this issue Oct 28, 2024
- runner creates two folders and uploads them as zipfiles
  - `/user_results`: provided to user
  - `/trusted_user_results`: provided to user if they have "full results" enabled by an admin
  - `/admin_results`: only visible to admins
- admin results are always uploaded, included for failed runs (for debugging)
- user results are only provided if the run was successful
- add `PREDICTCR_RUNNER_SCRIPT_DIR` env var to docker compose to specify where script & model can be found
- add /admin/result endpoint to download admin results zipfile
- switch from micromamba to miniconda docker image
  - reticulate doesn't seem to support micromamba, at least within docker
- re-enable runner docker image CI
- update runner README.md
- resolves #6
- resolves #43

Also refactor admin views using tabs
lkeegan added a commit that referenced this issue Oct 28, 2024
- runner creates three folders where the script runs, and uploads their contents as zipfiles:
  - `/user_results`: provided to user
  - `/trusted_user_results`: provided to user if they have "full results" enabled by an admin
  - `/admin_results`: only visible to admins
- admin results are always uploaded, included for failed runs (for debugging)
- user results are only provided if the run was successful
- add `PREDICTCR_RUNNER_SCRIPT_DIR` env var to docker compose to specify where script & model can be found
- add /admin/result endpoint to download admin results zipfile
- switch from micromamba to miniconda docker image
  - reticulate doesn't seem to support micromamba, at least within docker
- re-enable runner docker image CI
- update runner README.md
- resolves #6
- resolves #43

Also refactor admin views using tabs
lkeegan added a commit that referenced this issue Oct 28, 2024
- runner creates three folders where the script runs, and uploads their contents as zipfiles:
  - `/user_results`: provided to user
  - `/trusted_user_results`: provided to user if they have "full results" enabled by an admin
  - `/admin_results`: only visible to admins
- admin results are always uploaded, included for failed runs (for debugging)
- user results are only provided if the run was successful
- add `PREDICTCR_RUNNER_SCRIPT_DIR` env var to docker compose to specify where script & model can be found
- add /admin/result endpoint to download admin results zipfile
- switch from micromamba to miniconda docker image
  - reticulate doesn't seem to support micromamba, at least within docker
- re-enable runner docker image CI
- update runner README.md
- resolves #6
- resolves #43

Also refactor admin views using tabs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants