Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support level flag #429

Closed
tdenewiler opened this issue Jul 5, 2022 · 3 comments · Fixed by #436
Closed

Support level flag #429

tdenewiler opened this issue Jul 5, 2022 · 3 comments · Fixed by #436

Comments

@tdenewiler
Copy link
Contributor

Right now a new profile file has to be created to specify the desired level to run Statick. We should add support for setting a --level flag that overrides the level specified in the profile file.

@xydesa
Copy link
Collaborator

xydesa commented Jul 13, 2022

Would this be applied to all packages? even if they have a non-default level specified in the profile file?

@tdenewiler
Copy link
Contributor Author

That is a great question and we should provide guidance with unit tests to support our choice. I was thinking that a --level flag would override all other levels, even non-default levels specified in a --profile when running Statick. What do you think?

@xydesa
Copy link
Collaborator

xydesa commented Jul 13, 2022

I think that makes sense from a usability perspective. More granular configuration is available via the profile file, and I could see a user who uses the --level flag wanting just that level to run and nothing else. And being confused if other packages used a different level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants