Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "level" cli arg and unit tests. (#429) #436

Merged
merged 2 commits into from
Jul 25, 2022

Conversation

xydesa
Copy link
Collaborator

@xydesa xydesa commented Jul 14, 2022

"level" cli arg overrides any levels specified by the profile used.

Closes #429

@xydesa xydesa requested a review from denewiler July 14, 2022 01:12
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #436 (a4bca4d) into main (33f736f) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #436   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         3266      3269    +3     
=========================================
+ Hits          3266      3269    +3     
Impacted Files Coverage Δ
statick_tool/statick.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@denewiler
Copy link
Collaborator

denewiler commented Jul 25, 2022

I tested this against a ROS1 workspace and a pure Python package. They Python package has its own statick-config files. I opened config.yaml, copied the existing level, renamed the new level as tmp, then invoked Statick with a --level tmp flag. The Statick output showed it using the tmp level and the results were the same as the default level.

LGTM

@denewiler denewiler merged commit 62815a0 into sscpac:main Jul 25, 2022
xydesa added a commit to xydesa/statick that referenced this pull request Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support level flag
2 participants