Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli.search used deprecated get_all_items_as_dict #279

Closed
TomAugspurger opened this issue Jul 28, 2022 · 0 comments · Fixed by #284
Closed

cli.search used deprecated get_all_items_as_dict #279

TomAugspurger opened this issue Jul 28, 2022 · 0 comments · Fixed by #284

Comments

@TomAugspurger
Copy link
Collaborator

Followup to #277.

In

pystac-client/pystac_client/cli.py

Line 30 in caf8dd2

feature_collection = result.get_all_items_as_dict()
cli.search uses the deprecated get_all_items_as_dict.

It should be updated to use the replacement.
TomAugspurger pushed a commit to TomAugspurger/pystac-client that referenced this issue Jul 28, 2022
Un-deprecate get_all_items_as_dict
932f28d 
Followup to stac-utils#277 and
closes stac-utils#279

the `cli.search` and `get_all_items()` / `item_collection()` were using
this deprecated method. Users using non-deprecated APIs shouldn't be
getting deprecation warnings.

Clearly it's useful, so let's either un-deprecate it or move the
implementaiton to a private method and call that directly. I've chosen
to un-deprecate it.

I've also configured pytest to fail on warnings, to catch this type of
issue in CI.
@TomAugspurger TomAugspurger mentioned this issue Jul 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement new ItemSearch result consumers TomAugspurger/pystac-client
1 participant
@TomAugspurger