Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds an ItemSearch.item_collection method as a replacement for
the deprecated
get_all_items()
.A few other notes:
max_items
changes being workedout in Replacement functionality for get_all_items #237. That
can be done before / after this PR once things are ironed out
get_all_items
method to use Sphinx's builtindeprecated
directive.I'd like to enable pytest's
-W error
flag to fail on warnings. Butit looks like the
cli
is using the (deprecated)get_all_items_as_dict
method. I haven't touched that in this PR, but I don't think the CLI
should be using a deprecated function.
PR Checklist: