Remove mention of STAC_URL in Client.open docstring #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation was not updated after #81 to indicate that the `STAC_URL` environment variable doesn't work anymore. An argument to the `url` parameter is now required.
5 tasks
weiji14
changed the title
TomAugspurger
approved these changes
Sep 17, 2022
|
Thanks! |
weiji14
added a commit
to weiji14/zen3geo
that referenced
this pull request
May 17, 2023
The STAC_URL environment variable never actually worked, see stac-utils/pystac-client#317. Also updated some links on the walkthrough to point to torchdata 0.6.1.
weiji14
added a commit
to weiji14/zen3geo
that referenced
this pull request
May 17, 2023
) * 🥚 Allow using XpySTACAssetReader without xpystac when engine!=stac A little hidden feature to use `read_from_xpystac` with other engines (e.g. `netcdf4`, `h5netcdf`) without having to install `xpystac`! Added a unit test using `engine="rasterio"` which is technically deprecated, but works without having to install extra dependencies. * ✏️ Remove mention of the STAC_URL environment variable The STAC_URL environment variable never actually worked, see stac-utils/pystac-client#317. Also updated some links on the walkthrough to point to torchdata 0.6.1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
Description:
Quick patch that updates the docstring of
pystac_client.Client.opento remove mentioning theSTAC_URLenvironment variable, since it doesn't work anymore.Actually got a bit confused because the v0.2.0 changelog at https://github.com/stac-utils/pystac-client/blob/v0.5.0/CHANGELOG.md#v020---2021-08-04 says the fallback
STAC_URLwas added in #48 (5 May 2021), but the option was removed afterwards in #81 (2 Aug 2021) 😅Discovered this when writing unit tests at weiji14/zen3geo#59 and was wondering why I kept getting
AttributeError: 'NoneType' object has no attribute 'lower'when usingurl=Nonewith theSTAC_URLenvironment variable set. This was using pystac-client v0.4.0, but I think it's an issue from v0.2.0 to v0.5.0.PR Checklist: