Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🥚 Allow using XpySTACAssetReader without xpystac when engine!=stac #100

Merged
merged 2 commits into from
May 17, 2023

Conversation

weiji14
Copy link
Owner

@weiji14 weiji14 commented May 17, 2023

A little hidden feature to use read_from_xpystac with other engines (e.g. netcdf4, h5netcdf) without having to install xpystac! Added a unit test using engine="rasterio" which is technically deprecated, but works without having to install extra dependencies.

Patches #87

P.S. Happy 100th PR/Issue zen3geo 🥳

A little hidden feature to use `read_from_xpystac` with other engines (e.g. `netcdf4`, `h5netcdf`) without having to install `xpystac`! Added a unit test using `engine="rasterio"` which is technically deprecated, but works without having to install extra dependencies.
@weiji14 weiji14 added the feature New feature or request label May 17, 2023
@weiji14 weiji14 added this to the 0.6.x milestone May 17, 2023
@weiji14 weiji14 self-assigned this May 17, 2023
The STAC_URL environment variable never actually worked, see stac-utils/pystac-client#317. Also updated some links on the walkthrough to point to torchdata 0.6.1.
@weiji14 weiji14 marked this pull request as ready for review May 17, 2023 02:57
@weiji14 weiji14 merged commit 71ab786 into main May 17, 2023
@weiji14 weiji14 deleted the xpystac_without_xpystac branch May 17, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant