Skip to content

feat: HBase resolvable endpoints #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

feat: HBase resolvable endpoints #1159

wants to merge 25 commits into from

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Jun 11, 2025 •
edited
Loading

Description

fixes: stackabletech/hbase-operator#641

Warning

Merge this at the same time as stackabletech/hbase-operator#639, otherwise tests will break!

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@adwk67 adwk67 mentioned this pull request Jun 11, 2025
Open
@adwk67 adwk67 moved this to Development: In Progress in Stackable Engineering Jun 16, 2025
@adwk67 adwk67 self-assigned this Jun 16, 2025
@adwk67 adwk67 mentioned this pull request Jun 16, 2025
Open
15 tasks
@adwk67 adwk67 marked this pull request as ready for review June 16, 2025 14:10
@adwk67 adwk67 mentioned this pull request Jun 16, 2025
Open
@adwk67 adwk67 moved this from Development: In Progress to Development: Waiting for Review in Stackable Engineering Jun 16, 2025
@nightkr nightkr self-requested a review June 24, 2025 10:34
nightkr
nightkr reviewed Jun 24, 2025
View reviewed changes
@nightkr nightkr moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Jun 24, 2025
adwk67 and others added 4 commits June 24, 2025 17:44
@adwk67 @nightkr
Update hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-p…
f08e1c5 
…ort-and-use-alternative-p.patch

Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
@adwk67 @nightkr
Update hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-p…
d98ac32 
…ort-and-use-alternative-p.patch

Co-authored-by: Natalie Klestrup Röijezon <nat@nullable.se>
@adwk67
review comments: added constants etc.
bd0b75e
@adwk67
merge main and fix conflicts
a6a7e10
nightkr
nightkr reviewed Jun 25, 2025
View reviewed changes
nightkr
nightkr reviewed Jun 27, 2025
View reviewed changes
Copy link
Member

@nightkr nightkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor notes, but we're definitely closing in.

If you want to rush it in, we could probably merge 0005 as is, and split 0006 into a separate PR (though that will definitely require coordinating with the operator PR too..).

hbase/hbase/stackable/bin/hbase-entrypoint.sh
Comment on lines +83 to +86
sed -i -e s/\$\{HBASE_SERVICE_HOST\}/"${HBASE_SERVICE_HOST}"/g /stackable/conf/hbase-site.xml
sed -i -e s/\$\{HBASE_SERVICE_PORT\}/"${HBASE_SERVICE_PORT}"/g /stackable/conf/hbase-site.xml
sed -i -e s/\$\{HBASE_LISTENER_ENDPOINT\}/"${HBASE_LISTENER_ENDPOINT}"/g /stackable/conf/hbase-site.xml
sed -i -e s/\$\{HBASE_INFO_PORT\}/"${HBASE_INFO_PORT}"/g /stackable/conf/hbase-site.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for this to not be using https://github.com/stackabletech/config-utils instead of sed? AFAIU we already pull it in via stackable-base.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not used config-utils before: not sure how to template the file without first declaring the env-vars. I'll have a look.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, forget that last comment, we already have the env-vars in the context of entrypoint.sh. I'll try it out.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will defer this to #1191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightkr nightkr nightkr left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@adwk67 adwk67

Labels
None yet
Projects
Stackable Engineering
Status: Development: In Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Node-IPs for external reachability and localities
2 participants
@adwk67 @nightkr