-
-
Notifications
You must be signed in to change notification settings - Fork 7
feat: HBase resolvable endpoints #1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adwk67
wants to merge
25
commits into
main
Choose a base branch
from
feat/hbase-resolvable-endpoints
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
0fbe36b
patches I
adwk67 b5f96d5
patches I
adwk67 303739e
wip: patch hbase to use listener endpoints
adwk67 8dc1c99
changed rendering
adwk67 bd17a9e
rework patch for UI
adwk67 4a5df3b
Merge branch 'main' into feat/hbase-resolvable-endpoints
nightkr 2a2a5ac
Consistently override the advertised ports
nightkr 9ef046c
add listener endpoint and info port to hbase-site.xml
adwk67 99fd166
patch and entrypoint refactoring
adwk67 9953042
hbase: use listener service for region mover
adwk67 9b02ec8
Merge branch 'main' into feat/hbase-resolvable-endpoints
adwk67 4b6b849
hbase: patch for 2.6.2 endpoints
adwk67 be89d58
Merge branch 'main' into feat/hbase-resolvable-endpoints
adwk67 ceba85b
removed dead variable
adwk67 f08e1c5
Update hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-p…
adwk67 d98ac32
Update hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-p…
adwk67 bd0b75e
review comments: added constants etc.
adwk67 a6a7e10
merge main and fix conflicts
adwk67 de0c6c7
set RPC_CLIENT_SPECIFY_HOST to true by default
adwk67 496444d
corrected constant descriptions
adwk67 3fa6301
updated 2.6.2 patch
adwk67 ee7ea2e
patch 2.6.1 to reverse bound/advertised properties
adwk67 7a4340e
property re-working for 2.6.2
adwk67 f3d3596
Merge branch 'main' into feat/hbase-resolvable-endpoints
adwk67 65aaae2
provide advertised port as a fallback, removed changes to test class
adwk67 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for this to not be using https://github.com/stackabletech/config-utils instead of sed? AFAIU we already pull it in via stackable-base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've not used config-utils before: not sure how to template the file without first declaring the env-vars. I'll have a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, forget that last comment, we already have the env-vars in the context of entrypoint.sh. I'll try it out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will defer this to #1191