-
-
Notifications
You must be signed in to change notification settings - Fork 15
Merge typed role and rolegroup configs before converting to product-config maps #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@teozkr could you please add a link / quick explanation what this is blocked on? |
@teozkr ping |
Ah sorry, @lfrancke. This is blocked on GREsau/schemars#167, which is required in order to set up the correct type bounds in the generated schemas. |
If we don't get any feedback here, is there anything we can reasonably do? |
Currently, overriding gets pretty tricky, since reasonable-looking code like this:
is subtly wrong, since the rolegroup's default
port
will override an explicitly specifiedrole
-levelport
. #282 made this somewhat worse, since it now triggers for all rolegroups (whereas previously it would only trigger for rolegroups that specified aconfig:
field), but the issue was still there before.The text was updated successfully, but these errors were encountered: