Skip to content

Default Role/RoleGroup configuration when deserializing #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 16, 2021
Merged

Default Role/RoleGroup configuration when deserializing #282

merged 5 commits into from
Dec 16, 2021

Conversation

@nightkr
Copy link
Contributor

@nightkr nightkr commented Dec 13, 2021 •
edited
Loading

Description

Fixes #281

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)

@nightkr nightkr requested a review from a team December 13, 2021 13:47
@nightkr nightkr self-assigned this Dec 13, 2021
maltesander
maltesander reviewed Dec 16, 2021
View reviewed changes
nightkr
nightkr commented Dec 16, 2021
View reviewed changes
@nightkr
Copy link
Contributor Author

nightkr commented Dec 16, 2021

LGTM

Time to give bors the go-ahead?

maltesander
maltesander approved these changes Dec 16, 2021
View reviewed changes
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maltesander
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 16, 2021

Build succeeded:

@bors bors bot merged commit 828b0ca into main Dec 16, 2021
@bors bors bot deleted the bugfix/role-config-default branch December 16, 2021 10:02
@nightkr nightkr mentioned this pull request Dec 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltesander maltesander maltesander approved these changes

Assignees

@nightkr nightkr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Configuration::compute_* is not invoked if RoleGroup object doesn't define config field

3 participants

@nightkr @maltesander