Skip to content

Disable service links #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Disable service links #305

merged 2 commits into from
Feb 3, 2022

Conversation

nightkr
Copy link
Member

@nightkr nightkr commented Feb 3, 2022

Description

This causes K8s to generate a bunch of environment variables that may break the system being ran, causing issues such as stackabletech/spark-operator#256.

This is technically breaking, but this "feature" is virtually unused anyway.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)

@nightkr nightkr self-assigned this Feb 3, 2022
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a wonderful world to live in, when PRs are ready before issues are written.

@nightkr
Copy link
Member Author

nightkr commented Feb 3, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Feb 3, 2022

@bors bors bot merged commit 6db66d7 into main Feb 3, 2022
@bors bors bot deleted the bugfix/disable-service-links branch February 3, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PodBuilder should by default disable service links
2 participants