Skip to content
This repository was archived by the owner on Jul 20, 2022. It is now read-only.

[Merged by Bors] - Bugfix: naming the cluster spark doesn't break the master pods. #256

Closed
wants to merge 3 commits into from

Conversation

razvan
Copy link
Member

@razvan razvan commented Feb 3, 2022

Description

Please add a description here. This will become the commit message of the merge request later.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@razvan razvan requested a review from a team February 3, 2022 14:57
Copy link
Member

@maltesander maltesander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
@razvan
Copy link
Member Author

razvan commented Feb 3, 2022

bors r+

bors bot pushed a commit that referenced this pull request Feb 3, 2022
## Description

*Please add a description here. This will become the commit message of the merge request later.*
@bors
Copy link
Contributor

bors bot commented Feb 3, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Bugfix: naming the cluster spark doesn't break the master pods. [Merged by Bors] - Bugfix: naming the cluster spark doesn't break the master pods. Feb 3, 2022
@bors bors bot closed this Feb 3, 2022
@bors bors bot deleted the bugfix/make-kuttl-tests-successful branch February 3, 2022 15:46
bors bot added a commit to stackabletech/operator-rs that referenced this pull request Feb 3, 2022
305: Disable service links r=teozkr a=teozkr

## Description
This causes K8s to generate a bunch of environment variables that may break the system being ran, causing issues such as stackabletech/spark-operator#256.

This is technically breaking, but this "feature" is virtually unused anyway.

## Review Checklist
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added (or not applicable)
- [ ] Documentation added (or not applicable)
- [ ] Changelog updated (or not applicable)


Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants