This repository was archived by the owner on Jul 20, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2
[Merged by Bors] - Bugfix: naming the cluster spark doesn't break the master pods. #256
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightkr
reviewed
Feb 3, 2022
maltesander
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
nightkr
reviewed
Feb 3, 2022
Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
4 tasks
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 3, 2022
## Description *Please add a description here. This will become the commit message of the merge request later.*
Pull request successfully merged into main. Build succeeded: |
bors bot
added a commit
to stackabletech/operator-rs
that referenced
this pull request
Feb 3, 2022
305: Disable service links r=teozkr a=teozkr ## Description This causes K8s to generate a bunch of environment variables that may break the system being ran, causing issues such as stackabletech/spark-operator#256. This is technically breaking, but this "feature" is virtually unused anyway. ## Review Checklist - [ ] Code contains useful comments - [ ] (Integration-)Test cases added (or not applicable) - [ ] Documentation added (or not applicable) - [ ] Changelog updated (or not applicable) Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please add a description here. This will become the commit message of the merge request later.
Review Checklist
Once the review is done, comment
bors r+
(orbors merge
) to merge. Further information