feat!: Add OIDC AuthClass provider #680

sbernauer · 2023-10-27T12:20:28Z

Description

Created during hackathon

Definition of Done Checklist

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
Please make sure all these things are done and tick the boxes

Author

Give feedback

Changes are OpenShift compatible
CRD changes approved
Integration tests passed (for non trivial changes)
Options

Reviewer

Give feedback

Code contains useful comments
(Integration-)Test cases added
Documentation added or updated
Changelog updated
Cargo.toml only contains references to git tags (not specific commits or branches)
Options

Acceptance

Give feedback

Feature Tracker has been updated
Proper release label has been added
Options

sbernauer · 2023-11-27T09:51:58Z

I did a review of the code others have written and the current state LGTM.
As I have written parts of the code as well someone else needs to review as well :)

Techassi

First look, need to take a look again after the ADR is done.

src/commons/authentication/mod.rs

src/commons/authentication/oidc.rs

src/commons/s3.rs

src/error.rs

This reverts commit bd701f7. The Option<enum> still was represented as mandatory (oneOf oidc) in the CRD :(

Techassi

LGTM, only minor nits.

src/commons/authentication/mod.rs

src/commons/authentication/oidc.rs

sbernauer and others added 23 commits October 24, 2023 11:17

doc: Add fixme notes on commons S3 struct regarding Option<>x

86d0860

test: Add some smoke tests to ldap AuthClass

ce826fa

WIP, gl & hf

7464de8

Minor adjustments, add endpoint tests

de36231

Rename TlsClientUsage to TlsClientDetails

107f8ed

Add doc comments for OidcAuthenticationProvider

cc4b93e

Add OIDC provider to auth class enum

b1442c1

Adjust imports / exports

245c2ae

refactor: Prevent miss-use by making certain fields private

f0bff65

Add IPv6 hostname test

bff4a25

Add scopes and mandatory Vec<String>

1276fe2

refactor: Make tls property in the authentication providers public again

172e4ee

feat: Add helper functions for client env vars

5b1473c

fix: Use hex encoding instead of decimal

5cfc802

Add "provider" attribute

1b937f8

Update OIDC auth provider, add common client/product level auth options

03f07c5

Move TLS related structs to tls module

61d850b

Merge branch 'main' into feat/sso-auth-classes

3f7b5b5

Add AuthenticationProvider::new

06f5209

Add UrlExt trait

3b9629c

Add UrlExt example

86175d7

Rename TLS functions

256ed37

Comment out LDAP variant

33b73de

Techassi mentioned this pull request Nov 16, 2023

Tracking: OIDC support stackabletech/issues#462

Open

Techassi and others added 3 commits November 17, 2023 10:12

Add resolve_class function impl

5cbfba2

fix: Change field visibility

f91bfba

Add ClientAuthenticationDetails::authentication_class_name

c44535a

sbernauer force-pushed the feat/sso-auth-classes branch from a0de631 to c44535a Compare November 17, 2023 10:20

sbernauer added 2 commits November 17, 2023 11:30

Make ClientAuthenticationDetails::config pub

23eee45

fix: clientCredentialsSecret field name

90bdd2d

docs: Document ClientAuthenticationDetails::oidc_or_error

91fc0a6

sbernauer assigned Techassi and sbernauer Nov 27, 2023

sbernauer added 3 commits November 27, 2023 09:25

Add default for T for ClientAuthenticationOptions

8825aae

docs: Make less bloated for CRD descriptions

a0428b1

fix typo

6dd55f1

sbernauer requested review from NickLarsenNZ and Techassi November 27, 2023 09:52

Techassi requested changes Nov 27, 2023

View reviewed changes

sbernauer added 3 commits November 27, 2023 11:52

re-order imports

75d7cea

Rename extra_fields_for_product to product_specific_fields

151dcc6

Switch oidc from Option<> to an Option<enum>

bd701f7

sbernauer force-pushed the feat/sso-auth-classes branch from fceb611 to bd701f7 Compare November 27, 2023 12:43

sbernauer added 3 commits November 28, 2023 09:02

Revert "Switch oidc from Option<> to an Option<enum>"

2918d85

This reverts commit bd701f7. The Option<enum> still was represented as mandatory (oneOf oidc) in the CRD :(

Merge branch 'main' into feat/sso-auth-classes

11185cc

add comment on enum

ab7b08e

sbernauer force-pushed the feat/sso-auth-classes branch from b54534f to ab7b08e Compare November 30, 2023 07:28

sbernauer requested a review from Techassi November 30, 2023 07:31

Merge branch 'main' into feat/sso-auth-classes

cc4df3a

sbernauer added the status/blocker label Dec 4, 2023

Techassi requested changes Dec 4, 2023

View reviewed changes

src/commons/authentication/mod.rs Outdated Show resolved Hide resolved

src/commons/authentication/oidc.rs Show resolved Hide resolved

src/commons/authentication/oidc.rs Show resolved Hide resolved

docs: Fix wrong mention of flattening

3bad60c

sbernauer requested a review from Techassi December 4, 2023 14:03

Techassi approved these changes Dec 4, 2023

View reviewed changes

sbernauer added this pull request to the merge queue Dec 4, 2023

Merged via the queue into main with commit 307ac4a Dec 4, 2023

sbernauer deleted the feat/sso-auth-classes branch December 4, 2023 14:20

sbernauer removed the status/blocker label Dec 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: Add OIDC AuthClass provider #680

feat!: Add OIDC AuthClass provider #680

sbernauer commented Oct 27, 2023 •

edited

Loading

Author

Reviewer

Acceptance

sbernauer commented Nov 27, 2023

Techassi left a comment

Techassi left a comment

feat!: Add OIDC AuthClass provider #680

feat!: Add OIDC AuthClass provider #680

Conversation

sbernauer commented Oct 27, 2023 • edited Loading

Description

Definition of Done Checklist

Author

Reviewer

Acceptance

sbernauer commented Nov 27, 2023

Techassi left a comment

Choose a reason for hiding this comment

Techassi left a comment

Choose a reason for hiding this comment

sbernauer commented Oct 27, 2023 •

edited

Loading