Skip to content

refactor!: Don't parse resolv.conf for cluster domain auto-detection #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Oct 23, 2024

Conversation

sbernauer
Copy link
Member

@sbernauer sbernauer commented Oct 22, 2024

Description

Basically reverts #893 (and #895).
Instead we have no auto-detection and only have a config option (via env var and CLI arg) - if not specified we default to cluster.local.
Also this PR moves from a OnceLock to a KubernetesClusterInfo struct, which is passed around in operators to avoid implicit knowledge about call-orders.

We will create a discussion to decide on the auto-detection.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

Preview Give feedback

Reviewer

Preview Give feedback

Acceptance

Preview Give feedback

@sbernauer sbernauer self-assigned this Oct 22, 2024
@sbernauer sbernauer changed the title refactor!: Don't parse resolv.conf for cluster domain refactor!: Don't parse resolv.conf for cluster domain auto-detection Oct 22, 2024
NickLarsenNZ
NickLarsenNZ previously approved these changes Oct 22, 2024
Copy link
Member

@NickLarsenNZ NickLarsenNZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nightkr
nightkr previously approved these changes Oct 22, 2024
nightkr
nightkr previously approved these changes Oct 22, 2024
Techassi
Techassi previously approved these changes Oct 22, 2024
@sbernauer sbernauer added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 75a8b5c Oct 23, 2024
10 checks passed
@sbernauer sbernauer deleted the spike/domain-in-client branch October 23, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants