Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Resources limits #147

Closed
wants to merge 12 commits into from
Closed

[Merged by Bors] - Resources limits #147

wants to merge 12 commits into from

Conversation

adwk67
Copy link
Member

@adwk67 adwk67 commented Sep 27, 2022 •
edited by razvan
Loading

Description

Define resource limits for job, driver and executor pods.
Fixes #128

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

@adwk67 adwk67 marked this pull request as ready for review September 29, 2022 11:02
@razvan razvan self-requested a review September 29, 2022 12:23
razvan
razvan reviewed Sep 29, 2022
View reviewed changes
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass and it looks good. One question though.

tests/templates/kuttl/resources/13-assert.yaml Show resolved Hide resolved
@adwk67
Copy link
Member Author

adwk67 commented Sep 29, 2022

bors merge

bors bot pushed a commit that referenced this pull request Sep 29, 2022
@adwk67
Resources limits (#147)
38698ad 
# Description

Define resource limits for job, driver and executor pods.
Fixes #128
@bors
Copy link

bors bot commented Sep 29, 2022

Pull request successfully merged into main.

Build succeeded:

@bors bors bot changed the title Resources limits [Merged by Bors] - Resources limits Sep 29, 2022
@bors bors bot closed this Sep 29, 2022
@bors bors bot deleted the resources_limits branch September 29, 2022 14:25
@razvan razvan mentioned this pull request Sep 29, 2022
Closed
17 tasks
@sbernauer sbernauer mentioned this pull request Oct 12, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbernauer sbernauer sbernauer left review comments

@razvan razvan razvan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement resource limits and requests for Spark pods
3 participants
@adwk67 @razvan @sbernauer