Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build (actions): Update node version from 12 to 16 #210

Closed
wants to merge 0 commits into from

Conversation

l2D
Copy link

@l2D l2D commented Mar 15, 2023

Description of the change

Node 12 has been out of support since April 2022. This PR will use Node 16 to build GitHub Actions.

This PR was made by following GitHub Action Document – runs-for-javascript-actions

Screenshot:

2023-03-15T14-25-33_CJcPvCKU

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

None

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@l2D l2D requested a review from a team as a code owner March 15, 2023 14:35
@Bwvolleyball
Copy link
Contributor

Looks like there could be something going on with our builds - let me update some things on my end and re-run these.

@Bwvolleyball
Copy link
Contributor

Thanks @l2D - we had to create another branch with these changes because of how we have our CI setup using secrets - we'll try to cut a release of this soon as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants