Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to Node16 #211

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Bump to Node16 #211

merged 1 commit into from
Mar 15, 2023

Conversation

Bwvolleyball
Copy link
Contributor

Description of the change

Mimicking the changes from #210 but from inside the repo so that the builds get all build secrets, as currently, PRs from forks don't receive GHA secrets..

replace me

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

ISSUE-ID

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@Bwvolleyball Bwvolleyball requested a review from a team as a code owner March 15, 2023 17:15
@Bwvolleyball Bwvolleyball merged commit 316ef24 into main Mar 15, 2023
@Bwvolleyball Bwvolleyball deleted the feature/node-16 branch March 15, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-co-white d-co-white d-co-white approved these changes

@ValentinaPanic ValentinaPanic ValentinaPanic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bwvolleyball @ValentinaPanic @d-co-white