Update to use the runtime in stacks-blockchain #57
Conversation
|
Could you please explain why you removed the |
obycode
force-pushed
the
feat/clarity-wasm-runtime
branch
2 times, most recently
from
6a885ab
to
23c07c2
Compare
|
Rebased on top of latest |
obycode
force-pushed
the
feat/clarity-wasm-runtime
branch
2 times, most recently
from
647f1fc
to
8221579
Compare
After running through the entire module, we can then set the stack-pointer to point to the end of the literal memory. Without doing that, then writing to a functions stack could overwrite the literals. This was happening with the previous solution that was setting the global in the `.top-level` function, but because that runs in a separate environment from calls to that contract, that made no difference. The initial value needed to be changed instead.
obycode
force-pushed
the
feat/clarity-wasm-runtime
branch
from
8221579
to
4810501
Compare
|
I'm not sure how to fix that clippy error from our testing macro... |
|
That is already fixed in main https://github.com/stacks-network/clarity-wasm/blob/0fbfc1ae8bd93a03a806734e9a525b0cda1915e3/tests/tests/lib_tests.rs#L63L65 Did you merge main into your branch? |
|
BTW, I know I was the one suggesting it, but the submodules makes the coding experience really poor on vscode. Clippy runs on the submodule, and I don't get why, since it should just run on the members of Cargo.toml. |
Strange, yes, I did rebase on top of main. This must've gotten lost in the merge somewhere. I will double check to ensure that merging didn't lose anything else. |
This was fixed in main, but was lost in the merge.
Clippy complained about the size of this error, so initially I had boxed the error, but it was pointed out in the PR that it is nicer to box the `LimitedCostTracker` instead.
This changeset together with stacks-network/stacks-core#3880 move the runtime parts of our Wasm runtime into the stacks-blockchain clarity package.