feat: Transaction signer acknowledging bitcoin transaction sign requests #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netrome
force-pushed
the
256-feature-transaction-signer-acknowledging-valid-bitcoin-transaction-sign-requests
branch
4 times, most recently
from
16a7bfd to
71252b1
Compare
netrome
force-pushed
the
256-feature-transaction-signer-acknowledging-valid-bitcoin-transaction-sign-requests
branch
from
71252b1 to
0146917
Compare
djordon
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #256
This PR adds a few utility functions for the transaction validation, but since the validation logic depends on transaction parsing logic we'll leave the validation to a follow-up