Skip to content

Conversation

@jferrant
Copy link
Contributor

No description provided.

jferrant and others added 30 commits September 18, 2025 09:19
This just adds the basic support for the syntax and some setup for the
full implementation.
That infrastructure is not setup for handling PoX state, and the
stacking tracking in the asset maps is not setup yet any way.
We decided to remove this because it doesn't really make sense.
Jiloc
Jiloc previously approved these changes Oct 17, 2025
obycode and others added 9 commits October 17, 2025 13:07
The type-checking should be charged based on the size of the value, not
the size of the allowed type (which may be much larger than the actual
value passed in). This improvement activates with epoch 3.3.

Fixes stacks-network#6425
…ing of breaking changes

Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
…ted-epoch-to-expected-output-in-consensus-tests

Add expected evaluated epoch to consensus tests
…hecking-cost

feat: improve type-checking cost computation in epoch 3.3
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
@jferrant jferrant dismissed stale reviews from Jiloc and federico-stacks via aeda2f6 October 21, 2025 16:31
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2025

CLA assistant check
All committers have signed the CLA.

@jacinta-stacks jacinta-stacks added this pull request to the merge queue Oct 22, 2025
Merged via the queue into stacks-network:aac-client-breaking with commit c215d2b Oct 22, 2025
303 of 307 checks passed
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 85.41304% with 671 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.68%. Comparing base (258e704) to head (aeda2f6).
⚠️ Report is 100 commits behind head on aac-client-breaking.

Files with missing lines Patch % Lines
stacks-node/src/tests/nakamoto_integrations.rs 73.51% 536 Missing ⚠️
clarity/src/vm/functions/post_conditions.rs 86.11% 45 Missing ⚠️
stackslib/src/chainstate/tests/consensus.rs 90.34% 28 Missing ⚠️
...lysis/type_checker/v2_1/natives/post_conditions.rs 93.05% 15 Missing ⚠️
...tackslib/src/chainstate/nakamoto/staging_blocks.rs 76.59% 11 Missing ⚠️
stackslib/src/chainstate/nakamoto/mod.rs 84.00% 8 Missing ⚠️
pox-locking/src/pox_4.rs 66.66% 7 Missing ⚠️
clarity/src/vm/contexts.rs 88.88% 5 Missing ⚠️
clarity-types/src/errors/analysis.rs 62.50% 3 Missing ⚠️
stackslib/src/clarity_vm/tests/costs.rs 97.95% 3 Missing ⚠️
... and 7 more
Additional details and impacted files
@@                   Coverage Diff                   @@
##           aac-client-breaking    #6596      +/-   ##
=======================================================
- Coverage                80.50%   79.68%   -0.83%     
=======================================================
  Files                      568      571       +3     
  Lines                   347858   351879    +4021     
=======================================================
+ Hits                    280053   280381     +328     
- Misses                   67805    71498    +3693     
Files with missing lines Coverage Δ
clarity-types/src/errors/mod.rs 76.74% <ø> (ø)
clarity-types/src/types/signatures.rs 92.60% <ø> (ø)
clarity/src/vm/analysis/arithmetic_checker/mod.rs 92.48% <100.00%> (ø)
clarity/src/vm/analysis/read_only_checker/mod.rs 87.73% <100.00%> (+1.18%) ⬆️
.../src/vm/analysis/type_checker/v2_05/natives/mod.rs 88.57% <ø> (ø)
clarity/src/vm/analysis/type_checker/v2_1/mod.rs 90.28% <ø> (ø)
...c/vm/analysis/type_checker/v2_1/tests/contracts.rs 95.75% <100.00%> (ø)
...ity/src/vm/analysis/type_checker/v2_1/tests/mod.rs 99.84% <ø> (ø)
clarity/src/vm/costs/cost_functions.rs 100.00% <100.00%> (ø)
clarity/src/vm/costs/costs_1.rs 100.00% <100.00%> (ø)
... and 35 more

... and 53 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 258e704...aeda2f6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.