Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slstr-lst strip (as opposed to "chips" or "frames") are not detected #18

Closed
pjhartzell opened this issue Jun 27, 2023 · 1 comment · Fixed by #19
Closed

slstr-lst strip (as opposed to "chips" or "frames") are not detected #18

pjhartzell opened this issue Jun 27, 2023 · 1 comment · Fixed by #19
Assignees
Labels
bug Something isn't working

Comments

@pjhartzell
Copy link
Contributor

Describe the bug

slstr-lst strip geometries are not corrected. In

if item.properties["s3:product_name"] == "slstr-lst" and item.id.endswith("_____"):

item.id.endswith("_____") is never True because the trailing underscores are stripped from the Item ID. Strip data does not have a frame number, so those trailing underscores are inserted as fill values. Brute force is to check for item ID length, something like len(item.id) == 57, which indicates there is no frame number (and, hence, the data is a "strip").

if item.properties["s3:product_name"] == "slstr-lst" and item.id.endswith("_____"):

To reproduce

Run create_item on a slstr-lst strip archive, e.g., S3A_SL_2_LST____20160518T063623_20160518T081722_20180929T115803_6059_004_177______LR1_R_NT_003.SEN3

Expected behavior
Strips to be detected.

@pjhartzell pjhartzell added the bug Something isn't working label Jun 27, 2023
ircwaves added a commit to ircwaves/sentinel3 that referenced this issue Jun 27, 2023
@ircwaves
Copy link
Contributor

ircwaves commented Jun 27, 2023

Makes sense. Missed it because that combo isn't in the pile of examples. Is there a doc on how to make those data-less netcdf files? I could add the one you referenced.

To use the same logic as before, I pulled the instance_id out of the file name instead. That seems to line up with Sentinel-3 anming conventions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants